feat: Excel input, OG share image, git-deployable build - #7
Merged
Conversation
- Web accepts .xlsx/.xls — SheetJS (patched 0.20.3 from the SheetJS CDN, not the CVE-affected npm build) parses the first sheet to CSV, code-split so it only loads when an Excel file is dropped. - Add a branded 1200x630 OG/Twitter share image (web/public/og.png) and the social meta tags, so datasink.dev links unfurl nicely. - vercel.json buildCommand now builds datasink/core before the web app, so the project can build from a Git clone (not just local prebuilt) — enabling repo-linked auto-deploys. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The body gradient bottomed out at near-white (#ecfeff), leaving the footer on a washed-out white band that clashed with the dark cards. End it in soft cyan (#a5f3fc) and pin it with background-attachment: fixed so it doesn't stretch on long (results-open) pages. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three follow-up polish items. xlsx + OG are already live on datasink.dev (deployed via the prebuilt CLI path); the build-command change here is what makes repo-linked auto-deploys possible.
Changes
.xlsx/.xls. SheetJS 0.20.3 from the SheetJS CDN (not the CVE-affected npmxlsx@0.18.5) parses the first sheet to CSV. Code-split, so it only loads when an Excel file is dropped.web/public/og.png+og:image/twitter:imagemeta (summary_large_image), so datasink.dev links unfurl nicely.vercel.jsonbuildCommandnow buildsdatasink/corebefore the web app, so Vercel can build from a Git clone (not just local prebuilt).The Vercel project's Root Directory must be set to
web(Settings → Build & Deployment → Root Directory). Without it, git builds run from the repo root, build the rootdatasinkpackage, and fail with "No Output Directory named public". Once Root Directory =web, merging this auto-deploys cleanly.Verification
summary_large_image, new bundle.🤖 Generated with Claude Code