fix: OG image footer + white strip - #8
Merged
Merged
Conversation
The card was rendered at device-scale 2, where headless chromium's innerHeight is ~543 (not 630), so the footer row sat below the captured viewport and the default-white html showed as a strip. Render in a 717px-tall window (innerHeight becomes 630) and crop to 1200x630 so the full card — datasink.dev footer + dots — is captured, with a dark html background as belt-and-braces. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OG card was rendered at device-scale 2, where headless chromium reports
innerHeight~543 (not 630). The footer row (datasink.dev · validate · dedupe · enrich · research · dots) fell just below the captured viewport, and the default-whitehtmlshowed as a strip at the bottom.Fix: render in a 717px-tall window (so
innerHeight= 630, full card paints), crop to 1200×630, and set a darkhtmlbackground as belt-and-braces. Footer restored, no white strip, crisp at 2×.🤖 Generated with Claude Code