Skip to content

fix: share-ready polish + model-agnostic LLM selection - #9

Merged
cursor[bot] merged 3 commits into
mainfrom
cursor/share-readiness-polish-baaa
Sep 4, 2026
Merged

fix: share-ready polish + model-agnostic LLM selection#9
cursor[bot] merged 3 commits into
mainfrom
cursor/share-readiness-polish-baaa

Conversation

@chrisschouk

@chrisschouk chrisschouk commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Why

Before sharing sink / datasink as a LinkedIn + chrisscho.uk case study, the public surface needed to be airtight. Audit found a red CI badge, vapourware agent-discovery claims, a broken Vercel git deploy, README drift, and LLM selection locked to a handful of shortcut models.

What changed

  • CI unblocked for pnpm 11: SheetJS xlsx integrity + core-js allowBuilds: false
  • Honest agent discovery: removed fake OAuth / OpenID / MCP HTTP cards; docs match the real surface
  • Added GET /api/health
  • Vercel git deploys: root vercel.json builds datasink + web → web/dist, serves edge functions from root api/
  • README / CONTRIBUTING: datasink.dev primary link, sink demo, four-phase tagline
  • Model-agnostic LLM selection:
    • --model <id> accepts any Anthropic/OpenAI model string
    • --provider anthropic|openai (or shortcuts) — same choice applied to soak and steep
    • Web BYOK panel: vendor toggle + free-form model field (OpenAI or Anthropic)
sink soak contacts.csv --provider openai --model gpt-4.1-mini
sink wash contacts.csv --provider anthropic --model claude-sonnet-4-5-20250514

Verified locally

  • 110 tests; lint / format / typecheck / build green
  • Web build succeeds with openai client bundled

After merge

  1. Confirm CI + Vercel green on main
  2. Confirm live: /llms.txt, /api/health, drop a CSV on datasink.dev
  3. Optional: set GitHub homepage to https://datasink.dev
  4. Optional: npm publish so package repository/homepage fields match

Safe share claims

Works without keys: scrub, rinse, spot, inspect, demo, browser scrub/rinse.
Needs BYOK: soak, steep (any Anthropic or OpenAI model).
Do not claim hosted OAuth, remote MCP, or a public contact API beyond health + Firecrawl proxy.

Open in Web Open in Cursor 

Unblock pnpm 11 CI (xlsx integrity + core-js allowBuilds), strip vapourware
OAuth/MCP claims from agent discovery, add /api/health, and point public docs
at datasink.dev / chrisschouk/sink-cli.

Co-authored-by: Chris Schofield <info@totalaudiopromo.com>
@vercel

vercel Bot commented Sep 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sink-web Ready Ready Preview Sep 4, 2026 8:58am UTC

Git deploys were building the monorepo root and looking for public/, so
preview/production stayed broken. Add root vercel.json → web/dist, promote
api/ + middleware to root, and align README provider docs with the CLI.

Co-authored-by: Chris Schofield <info@totalaudiopromo.com>
Add --model for any vendor model ID, apply the same LLM choice to soak and
steep, share alias resolution, and open the web BYOK panel to either vendor
with a free-form model field.

Co-authored-by: Chris Schofield <info@totalaudiopromo.com>
@cursor cursor Bot changed the title fix: share-ready polish — green CI, honest discovery, docs fix: share-ready polish + model-agnostic LLM selection Sep 4, 2026
@chrisschouk
chrisschouk marked this pull request as ready for review September 4, 2026 10:52
@cursor
cursor Bot merged commit 2d8da76 into main Sep 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants