Fix file watch for paths containing percent-encoded characters - #16
Open
stephanedupont wants to merge 1 commit into
Open
Fix file watch for paths containing percent-encoded characters#16stephanedupont wants to merge 1 commit into
stephanedupont wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15
setUpFileWatch()builds the path it passes toopen(_:O_EVTONLY)fromdirectoryURL.path().URL.path()defaults topercentEncoded: true, so any directory whose path contains characters that get percent-encoded (most commonly a space) is handed toopen()still encoded.For example, the default
Application Supportlocation becomes:open()expects a real filesystem path, not a URL-encoded one. There is no directory literally namedApplication%20Support, soopen()returns-1, thefileDescriptor > 0guard fails, and the watch silently fails with:This affects any store placed under
Library/Application Support(Apple's recommended location for this kind of file). Reads/writes are unaffected because they go throughNSFileCoordinator/URL-based APIs; only theopen()-based watch breaks.Using
path(percentEncoded: false)passes a properly decoded filesystem path toopen(), so the watch sets up correctly.