Vectorize#2
Open
tylerapritchard wants to merge 19 commits into
Open
Conversation
| return inView | ||
|
|
||
|
|
||
| def make_az_asym(coords): |
Owner
There was a problem hiding this comment.
I buy this let's ditch it! Thank you for the sanity check.
| cphi = np.cos(deg2rad * lng_deg) | ||
| sphi = np.sin(deg2rad * lng_deg) | ||
|
|
||
| xyfp = np.zeros((2,), dtype=np.double) |
Owner
There was a problem hiding this comment.
We don't need this line in Python
| sphi = np.sin(deg2rad * lng_deg) | ||
|
|
||
| xyfp = np.zeros((2,), dtype=np.double) | ||
| xyfp[0] = -cphi * rtanth |
Owner
There was a problem hiding this comment.
Suggested change
| xyfp[0] = -cphi * rtanth | |
| xyfp = [-cphi * rtanth, -sphi * rtanth] |
Owner
There was a problem hiding this comment.
TP points out that we should maybe be thinking about type checking here and make sure it's a float.
|
|
||
| xyfp = np.zeros((2,), dtype=np.double) | ||
| xyfp[0] = -cphi * rtanth | ||
| xyfp[1] = -sphi * rtanth |
Owner
There was a problem hiding this comment.
Suggested change
| xyfp[1] = -sphi * rtanth |
| if xy[0] >= 0.0: | ||
| if xy[1] >= 0.0: | ||
| self.ccd = 1 | ||
| ccdpx = xy_to_ccdpx(self, xy,) |
Owner
There was a problem hiding this comment.
Suggested change
| ccdpx = xy_to_ccdpx(self, xy,) | |
| ccdpx = xy_to_ccdpx(self, xy) |
| """Convert focal plane to pixel location also need to add in the | ||
| auxillary pixels added into FFIs | ||
| """ | ||
| #created xy_to_ccdpix function to minimize repeated math |
Owner
There was a problem hiding this comment.
Can you add a comment here describing what we're trying to achieve with this function, and what xy is?
| lat = lat / deg2rad | ||
| cut = star_in_fov(lng, lat) | ||
| if(cut): | ||
| lng=lng[cut] |
Owner
There was a problem hiding this comment.
Suggested change
| lng=lng[cut] | |
| lng = lng[cut] |
| lng = lng / deg2rad | ||
| lat = lat / deg2rad | ||
| cut = star_in_fov(lng, lat) | ||
| if(cut): |
Owner
There was a problem hiding this comment.
Suggested change
| if(cut): | |
| if cut: |
| ccdpx, fitpix = mm_to_pix(self,xyfp) | ||
| return inCamera, ccdNum, fitsxpos, fitsypos, ccdxpos, ccdypos | ||
| else: | ||
| print('No specified targets in Field of View') |
Owner
There was a problem hiding this comment.
use logger or warnings instead of print.
Owner
|
Things to add:
|
src/mwe-test new testing notebook
…torize into vectorize
Importing basic wrapper class sketch from christinahedges/tess-point vectorize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some vectorization updates