chore(task): complete task-4 deprecation and shortcut cleanup#1
Merged
Conversation
- Replace deprecated llama token decoding with token_to_piece and update workspace edition handling for Rust 2024 warnings. - Simplify translation submit behavior to Enter-only and remove fallback keys plus dead Enter handling paths in the TUI. - Update shortcut tests, UI hints, and the ExecPlan lifecycle by moving task-4 from active to completed with final notes. - Include AGENTS rule updates so commit workflow expectations stay explicit in-repo for future contributors.
- Normalize formatting in core and tui rust files to keep style consistent and avoid noisy diffs in later changes. - Update AGENTS guidance with the no-empty-line reminder so commit message expectations remain explicit.
- Clarify that unnecessary empty lines should be avoided in messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation