Fix compatibility with ONI: Spaced Out version 496912#8
Open
ThaRedstoner wants to merge 2 commits intochromiumboy:masterfrom
Open
Fix compatibility with ONI: Spaced Out version 496912#8ThaRedstoner wants to merge 2 commits intochromiumboy:masterfrom
ThaRedstoner wants to merge 2 commits intochromiumboy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I've updated your ExtendedBridges mod to support ONI: Spaced Out version 496912.
It seems that this update broke all mods that tried to inject their buildings into the plan screen at specific positions (after specific other buildings, for instance). Including this one.
I'm not really sure if there's still a way to do it like that, but for now on recommendation of Klei, I've made it use ModUtil.AddBuildingToPlanScreen, which should make sure this doesn't break again.
I've included a prebuilt binary for the mod itself, but I didn't update any of the other dlls included in the repository. I would recommend you to remove and/or git ignore them from your public repository as well, as any contributor should simply link those files themselves. (Since the dlls aren't meant to be uploaded, they're still property of their respective owners, like Klei and Unity)