Conversation
The chart created two Services (spectre and spectre-metrics) both exposing port 9090 with the same selector labels. The ServiceMonitor matched both, producing two identical scrape jobs (spectre and spectre-metrics) with ~38.7K duplicate series. - Remove service-metrics.yaml (duplicate metrics-only service) - Add metrics port (9090) to default service.ports in values.yaml - Add metricRelabelings support to ServiceMonitor template - Bump chart version 0.3.4 → 0.3.5
Contributor
Author
|
Downstream PR: chronicleprotocol/app-of-apps#1067 (consumes chart 0.3.5, adds metricRelabelings for holepunch metric) |
WesleyCharlesBlake
previously approved these changes
Feb 18, 2026
Member
|
just need to figure out why its failing here https://github.com/chronicleprotocol/charts/actions/runs/21892153998/job/63200110770?pr=275#step:9:50 could be issues with exposing metrics |
Metrics port 9090 is not available in CI kind cluster since spectre requires valid config/keys to start its metrics server. Only test the listen port for connectivity.
Contributor
Author
Fixed and will deploy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
service-metrics.yamlwhich created a duplicate Service (spectre-metrics) targeting the same pods as the mainspectreServicespectreandspectre-metrics)metricsport (9090) to defaultservice.portsinvalues.yamlso the main service always exposes the metrics endpointmetricRelabelingssupport to the ServiceMonitor templateImpact
spectre-metricswas an exact copy ofspectrespectre-metricsjob name (all usespectre)service.portsto includemetrics(e.g. prod-relay-appset) are unaffectedservice.portsnow get themetricsport from the main service instead of the removedservice-metricsserviceChanges
charts/spectre/templates/service-metrics.yamlcharts/spectre/values.yamlmetrics: {port: 9090}to defaultservice.ports, addmetricRelabelings: []charts/spectre/templates/servicemonitor.yamlmetricRelabelingsblock (gated on non-empty)charts/spectre/Chart.yamlDownstream
metricRelabelingsto droplibp2p_holepunch_address_outcomes_totalTest plan
helm templateproduces one Service withmetricsport (not two)helm templaterenders ServiceMonitor withoutmetricRelabelingswhen emptyhelm templaterenders ServiceMonitor withmetricRelabelingswhen values set