Support legacy RSA based CBC-mode cipher suites - #3
Merged
Merged
Conversation
Combine TLS_RSA_WITH_AES_256_CBC_SHA and TLS_RSA_WITH_AES_128_CBC_SHA with Go's default secure cipher suites. The goal is to achieve broader compatibility with older servers that require CBC-mode cipher suites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go's default set of cipher suites does not include RSA-based CBC-mode cipher suites. While they are considered legacy, there are many hosts in the wild that still use them. As an inspection tool, it makes sense that we support these cipher suites for broader compatibility.
Before
After
{ "hostname": "foobar.tld", "port": 443, "tls_version": "1.2", "cipher_suite": "TLS_RSA_WITH_AES_128_CBC_SHA", "leaf_expires_at": "2025-11-30T16:18:27Z", ... }