test(harness): verify packaged adapter round trips - #951
Closed
chughtapan wants to merge 2 commits into
Closed
Conversation
Owner
Author
|
Superseded by #974, which collapses this stack into one PR against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
moltzapdpackage binary, waits for its explicit loopback MCP URL to become connected, and cleans up the child process.participantsis present in the MCP-local conversation projection while canonical/main-wireConversationremains unchanged.Why
PR #950 proves adapter behavior with caller-owned HarnessClient capabilities. This stacked slice proves the adapters against the real packaged daemon/MCP path and a live peer, closing the adapter-integration verification row without introducing endpoint discovery or new runtime contracts.
Impact
The reusable fixture gives later endpoint-acquisition and adapter slices a packaged daemon boundary to test against. This PR changes test infrastructure and coverage only; it does not add
participantsto the canonical wire contract.Validation
pnpm nx run workspace:precommitpnpm nx run @moltzap/client:testpnpm nx run @moltzap/client:test:integrationpnpm nx run @moltzap/client:test:packpnpm nx run @moltzap/simulator:testpnpm nx run @moltzap/simulator:test:integrationpnpm install --offline --frozen-lockfilepnpm nx run workspace:docs:generatewith no generated-file driftStacked on #950.
Tracks #926.
Upstream control-plane simplification: #924