fix(modeler): keep default task marker visible with template icon#98
Open
ivanfarray-cib wants to merge 1 commit into
Open
fix(modeler): keep default task marker visible with template icon#98ivanfarray-cib wants to merge 1 commit into
ivanfarray-cib wants to merge 1 commit into
Conversation
Render the applied element-template icon in the opposite (top-right) corner on activities so the default task-type marker (user figure on user tasks, gears on service tasks, ...) stays visible as a reference instead of being replaced. Events still replace-and-center because a 36 px circle has no room for two icons. Also fix the bpmn-js handler lookup: the .find() over base types returns 'bpmn:Task' first for a UserTask, and handlers['bpmn:Task'] is the plain task handler with no marker. Prefer handlers[element.type] and fall back to baseType only for custom subclasses.
adrian90
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render the applied element-template icon in the opposite (top-right) corner on activities so the default task-type marker (user figure on user tasks, gears on service tasks, ...) stays visible as a reference instead of being replaced. Events still replace-and-center because a 36 px circle has no room for two icons.
Also fix the bpmn-js handler lookup: the .find() over base types returns 'bpmn:Task' first for a UserTask, and handlers['bpmn:Task'] is the plain task handler with no marker. Prefer handlers[element.type] and fall back to baseType only for custom subclasses.