Skip to content

feat(startProcess)!: introduce configurable access control for the "Start process" tile #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LuisMiguelSS wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −8
Open

feat(startProcess)!: introduce configurable access control for the "Start process" tile #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/public/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@
"filter": ["CREATE"]
},
"startProcess": {
"application": ["ALL"],
"processDefinition": ["READ", "CREATE_INSTANCE"],
"processInstance": ["CREATE"]
},
Expand Down
22 changes: 16 additions & 6 deletions frontend/src/components/CibSeven.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
</div>
</div>

<b-button v-if="$root.user && startableProcesses && $route.name === 'tasklist'" class="d-none d-sm-block py-0 me-3" variant="outline-secondary" :title="$t('start.startProcess.title')" @click="openStartProcess()">
<b-button v-if="$route.name === 'tasklist' && canStartProcesses" class="d-none d-sm-block py-0 me-3" variant="outline-secondary" :title="$t('start.startProcess.title')" @click="openStartProcess()">
<span class="mdi mdi-18px mdi-rocket"><span class="d-none d-lg-inline">{{ $t('start.startProcess.title') }}</span></span>
</b-button>

Expand Down Expand Up @@ -111,7 +111,7 @@
<AboutModal ref="about"></AboutModal>
<FeedbackModal ref="report" url="feedback" :email="$root.user && $root.user.email" @report="$refs.down.$emit('report', $event)"></FeedbackModal>

<GlobalEvents v-if="permissionsTaskList" @keydown.ctrl.left.prevent="$router.push('/seven/auth/start-process')"></GlobalEvents>
<GlobalEvents v-if="canStartProcesses" @keydown.ctrl.left.prevent="$router.push('/seven/auth/start-process')"></GlobalEvents>
<GlobalEvents v-if="permissionsCockpit" @keydown.ctrl.right.prevent="$router.push('/seven/auth/processes/list')"></GlobalEvents>
<GlobalEvents v-if="permissionsTaskList" @keydown.ctrl.down.prevent="$router.push('/seven/auth/tasks')"></GlobalEvents>

Expand Down Expand Up @@ -147,15 +147,22 @@ export default {
},
computed: {
menuItems: function() {
return [{
show: this.permissionsTaskList && this.startableProcesses,
groupTitle: 'start.taskList.title',
return [
{
show: this.canStartProcesses,
groupTitle: 'start.startProcess.title',
items: [{
to: '/seven/auth/start-process',
active: ['seven/auth/start-process'],
tooltip: 'start.startProcess.tooltip',
title: 'start.startProcess.title'
}, {
}
]
},
{
show: this.permissionsTaskList,
groupTitle: 'start.taskList.title',
items: [{
to: '/seven/auth/tasks',
active: ['seven/auth/tasks'],
tooltip: 'start.taskList.tooltip',
Expand Down Expand Up @@ -296,6 +303,9 @@ export default {
})
return title
},
canStartProcesses: function() {
return this.$root.user && this.applicationPermissions(this.$root.config.permissions.startProcess, 'startProcess')
},
permissionsTaskList: function() {
return this.$root.user && this.applicationPermissions(this.$root.config.permissions.tasklist, 'tasklist')
},
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/start/StartView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export default {
computed: {
tiles() {
const tiles = []
if (this.applicationPermissions(this.$root.config.permissions.tasklist, 'tasklist') && this.startableProcesses) {
if (this.applicationPermissions(this.$root.config.permissions.startProcess, 'startProcess')) {
tiles.push('startProcess')
}
if (this.applicationPermissions(this.$root.config.permissions.tasklist, 'tasklist')) {
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ const appRoutes = [
},

// Start new process (end-user)
{ path: 'start-process', name: 'start-process', beforeEnter: permissionsGuard('tasklist'),
{ path: 'start-process', name: 'start-process', beforeEnter: permissionsGuard('startProcess'),
component: StartProcessView
},

Expand Down