fix(embedded-forms, RenderTemplate): improve error handling#830
Open
dmitrymalk wants to merge 16 commits into
Open
fix(embedded-forms, RenderTemplate): improve error handling#830dmitrymalk wants to merge 16 commits into
dmitrymalk wants to merge 16 commits into
Conversation
…s and human-readable messages
…ponents using extractErrorMessage utility
…acting form names
… for deployed form not found errors
…ction utilities for better user feedback
…d adding response data parsing
dmitrymalk
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves error handling for form loading and submission by introducing a centralized error extraction utility and suppressing global error dialogs for deployed forms in iframes that handle their own errors via postMessage.
Changes:
- Added new
error.jsutility module with functions to extract user-friendly error messages from various error formats (Axios, BPM SDK) and detect specific form-related errors - Modified global error handler in
init.jsto skip error dialogs for deployed form routes ('deployed-form' and 'start-deployed-form') as they manage their own error display - Updated form components to use
extractErrorMessagefor consistent error message extraction and display custom messages for specific error patterns - Added translation keys for form-not-found and deployed-form-not-found errors across all language files (EN, DE, ES, RU, UA)
- Changed default error type in RenderTemplate.vue from 'errorSaveTask' to 'SystemException'
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/utils/error.js | New utility module with error extraction and form-specific error detection functions |
| frontend/src/utils/init.js | Added deployed form route detection to skip global error dialogs for iframe forms |
| frontend/src/embedded-form/embedded-form.js | Updated to use extractErrorMessage throughout and display custom messages for form errors |
| frontend/src/components/render-template/RenderTemplate.vue | Changed default error type and fixed indentation |
| frontend/src/components/forms/DeployedForm.vue | Added extractErrorMessage usage and custom handling for deployed form not found errors |
| frontend/src/components/forms/StartDeployedForm.vue | Added extractErrorMessage usage for consistent error display |
| frontend/src/assets/translations_*.json | Added formNotFound and deployedFormNotFound translation keys across all languages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
@dmitrymalk I've opened a new pull request, #831, to work on those changes. Once the pull request is ready, I'll request review from you. |
Contributor
|
@dmitrymalk I've opened a new pull request, #832, to work on those changes. Once the pull request is ready, I'll request review from you. |
Member
Author
serge-krot
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.