tracefs: discover mount via /proc/self/mountinfo#2004
Open
yoav-orca wants to merge 1 commit into
Open
Conversation
Lift the BPFFS mountinfo parser out of internal/sys into a new
internal/mountinfo package, parameterized by filesystem type, and reuse
it in internal/tracefs.
Tracefs auto-detection now consults /proc/self/mountinfo first: any
tracefs mount is accepted regardless of its path, and a debugfs mount
with an existing tracing/ subdirectory is used as a fallback. The
hardcoded /sys/kernel/{tracing,debug/tracing} probe via statfs remains
as a last-resort fallback for environments where mountinfo is
unavailable, and to keep behavior identical on kernels that predate
tracefs being lifted out of debugfs (Linux 4.1).
This removes the need for callers in containerized environments to
bind-mount tracefs at the kernel-canonical paths just to make
cilium/ebpf find it. internal/sys/token.go shrinks accordingly:
parseBPFFSMounts, readBPFFSMounts, and the unescape helper now live in
the new package and are tested there.
Closes cilium#2000
Signed-off-by: Yoav Alon <yoav@orca.security>
yoav-orca
force-pushed
the
feat/mountinfo-tracefs
branch
from
20dcdb3 to
02c30d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lift the BPFFS mountinfo parser out of internal/sys into a new internal/mountinfo package, parameterized by filesystem type, and reuse it in internal/tracefs.
Tracefs auto-detection now consults /proc/self/mountinfo first: any tracefs mount is accepted regardless of its path, and a debugfs mount with an existing tracing/ subdirectory is used as a fallback. The hardcoded /sys/kernel/{tracing,debug/tracing} probe via statfs remains as a last-resort fallback for environments where mountinfo is unavailable, and to keep behavior identical on kernels that predate tracefs being lifted out of debugfs (Linux 4.1).
This removes the need for callers in containerized environments to bind-mount tracefs at the kernel-canonical paths just to make cilium/ebpf find it.
Closes #2000