regexp for require msgs in commit#62
Merged
aanm merged 5 commits intoAug 28, 2023
Merged
Conversation
Signed-off-by: Alexandre Perrin <alex@isovalent.com>
See cilium/cilium#23110 Signed-off-by: Alexandre Perrin <alex@isovalent.com>
Signed-off-by: Alexandre Perrin <alex@isovalent.com>
Signed-off-by: Alexandre Perrin <alex@isovalent.com>
Before this patch when running `make clean` we get:
make: *** No rule to make target 'rm', needed by 'clean'. Stop.
Signed-off-by: Alexandre Perrin <alex@isovalent.com>
aanm
approved these changes
Aug 28, 2023
kaworu
commented
Aug 28, 2023
Comment on lines
-172
to
+177
| var cfg github.FlakeConfig | ||
| var cfg github.PRBlockerConfig |
Member
Author
There was a problem hiding this comment.
@aanm is this breaking the current client mode workflow? I guess the FlakeConfig has now to be under flake-tracker:, is that a problem?
Member
There was a problem hiding this comment.
It's fine, client mode is meant for development purposes anyway.
aanm
approved these changes
Aug 28, 2023
Comment on lines
-172
to
+177
| var cfg github.FlakeConfig | ||
| var cfg github.PRBlockerConfig |
Member
There was a problem hiding this comment.
It's fine, client mode is meant for development purposes anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
regexpMsgtorequire-msgs-in-commit, a regular expression alternative tomsg. Also brings client mode support forrequire-msgs-in-commiton the way so I could manually test the patch.client mode tests
Got a complain when checking for a missing
msg:No complain on kaworu/cilium#283 for an existing
msg:Got an error when neither
msgorregexpMsgis configured:Complains about no
regexpMsgmatch:No complain on kaworu/cilium#277 when
regexpMsgmatches: