Skip to content

part: Only reuse watches hash map when it is small #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joamaki merged 1 commit into from
Feb 23, 2026
Merged

part: Only reuse watches hash map when it is small #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion part/txn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,17 +199,26 @@ func (txn *Txn[T]) Commit() Tree[T] {
return t
}

// watchesReuseThreshold is the threshold at which the [txn.watches] hash
// map is reused for next transaction.
const watchesReuseThreshold = 64

// Notify closes the watch channels of nodes that were
// mutated as part of this transaction. Must be called before
// Tree.Txn() is used again.
func (txn *Txn[T]) Notify() {
for ch := range txn.watches {
close(ch)
}
clear(txn.watches)
if !txn.dirty && len(txn.watches) > 0 {
panic("BUG: watch channels marked but txn not dirty")
}
// Clear or reallocate the watches hash map for the next transaction.
if len(txn.watches) <= watchesReuseThreshold {
clear(txn.watches)
} else {
txn.watches = make(map[chan struct{}]struct{})
}
if txn.dirty && txn.rootWatch != nil {
close(txn.rootWatch)
txn.rootWatch = nil
Expand Down