test: fix flakiness in TestKprobeMatchParentBinaries#4828
Open
ethical-buddy wants to merge 2 commits into
Open
test: fix flakiness in TestKprobeMatchParentBinaries#4828ethical-buddy wants to merge 2 commits into
ethical-buddy wants to merge 2 commits into
Conversation
…binaries-flake test: fix flakiness in TestKprobeMatchParentBinaries
Contributor
|
Ehy thanks for this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Description
TestKprobeMatchParentBinarieswas asserting on the exportedProcessKprobe.Parentbinary, but thatis not the field used by the
matchParentBinariesselector in the exec-without-clone path.For same-process execs, the selector matches against the previous binary stored in
tg_parents_bin,while the exported
Parentfield is resolved separately from the real parent process. That made thetest validate the wrong observable and could fail even when selector behavior was correct.
This change keeps the test intent but makes the assertion direct and deterministic:
fd_installevent is emitted for the matching caseIt also restores
option.Config.ParentsMapEnabledwith cleanup to avoid leaking global test state.Changelog