bpf: add errmetrics more generously#4989
Draft
3u13r wants to merge 2 commits into
Draft
Conversation
Contributor
Author
|
Converted to draft until we are aligned in the issue. |
Contributor
|
For the failures that occur in In this PR I laid the groundwork to do this, and handled a |
Add errmetrics around function calls that don't yet handle the return code and can fail silently. Those are mostly calls of `probe_read` and `map_update_elem`. Note that we didn't add this to all such cases since we run against the instruction limit on 4.18 (rhel 8.10) and 4.19, but also on 5.10 if we try to add errmetrics to all cases. Fixes: cilium#4952 Signed-off-by: Leonard Cohnen <leonard.cohnen@gmail.com>
When an function argument cannot be read in eBPF, we have existing infrastructure to report this to the userspace. Use this infrastructure to report any read_probe errors in read_arg(). Related-to: cilium#4923 Signed-off-by: Leonard Cohnen <leonard.cohnen@gmail.com>
3u13r
force-pushed
the
pr/3u13r/add-more-errmetrics-2026-05-11
branch
from
222a6ed to
f84ff15
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mtardy
added
the
release-note/misc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4952
Description
Add errmetrics around function calls that don't yet handle the return code and can fail silently.
Those are mostly calls of
probe_readandmap_update_elem. Note that we didn't add this to all such cases since we run against the instruction limit on 4.19, but also on 5.10 if we try to add errmetrics to all cases.Changelog