Skip to content

Conversation

@ndpm13
Copy link

@ndpm13 ndpm13 commented Nov 5, 2025

Description

The other PR brings way too many changes and adds unnecessary deps. I've tested this on a Void Linux system since I can't run mainline cinny-desktop on it (due to some libsoup/javascriptcore errors).

Fixes #398

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ndpm13 ndpm13 marked this pull request as ready for review November 5, 2025 09:55
@ndpm13

This comment was marked as off-topic.

ajbura added a commit to cinnyapp/cla that referenced this pull request Nov 5, 2025
@ndpm13

This comment was marked as off-topic.

Copy link

@niklaskorz niklaskorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Enable desktop notifications" does not seem to do anything, and I get 401 Unauthorized for all media requests to my homeserver. Besides that, appears to work fine!

@ndpm13
Copy link
Author

ndpm13 commented Dec 15, 2025

"Enable desktop notifications" does not seem to do anything

I didn't notice that, it shouldn't be hard to fix. However, I have no idea how to work around the media error without patching the Cinny core itself 😅

@niklaskorz
Copy link

niklaskorz commented Dec 15, 2025

However, I have no idea how to work around the media error without patching the Cinny core itself 😅

The cinny issue suggests this to be related to the service worker not running in a secure context, see the comments here: cinnyapp/cinny#2274

However, evaluating window.isSecureContext in the Cinny Tauri console gives me true. 🤔

Edit:

Running await navigator.serviceWorker.getRegistrations() in the console shows that no service worker is registered! This might explain both the desktop notifications issue as well as the media authorization issues.

}
],
"security": {
"csp": "script-src blob: data: filesystem: ws: wss: http: https: tauri: 'unsafe-eval' 'unsafe-inline' 'self' img-src: 'self'"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this expects an object now, instead of a string:

https://v2.tauri.app/security/csp/

@ndpm13
Copy link
Author

ndpm13 commented Dec 15, 2025

...Notifications aren't working correctly for me in the browser, not only in Tauri. Any ideas what's that about?

@nyabinary
Copy link

How long until do you think this will take to land? Because we don't want to maintain this as a patch if possible in nixpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use tauri v2

3 participants