-
-
Notifications
You must be signed in to change notification settings - Fork 69
Upgrade Tauri from v1 to v2 #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
niklaskorz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Enable desktop notifications" does not seem to do anything, and I get 401 Unauthorized for all media requests to my homeserver. Besides that, appears to work fine!
I didn't notice that, it shouldn't be hard to fix. However, I have no idea how to work around the media error without patching the Cinny core itself 😅 |
The cinny issue suggests this to be related to the service worker not running in a secure context, see the comments here: cinnyapp/cinny#2274 However, evaluating Edit: Running |
| } | ||
| ], | ||
| "security": { | ||
| "csp": "script-src blob: data: filesystem: ws: wss: http: https: tauri: 'unsafe-eval' 'unsafe-inline' 'self' img-src: 'self'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this expects an object now, instead of a string:
|
...Notifications aren't working correctly for me in the browser, not only in Tauri. Any ideas what's that about? |
|
How long until do you think this will take to land? Because we don't want to maintain this as a patch if possible in |
Description
The other PR brings way too many changes and adds unnecessary deps. I've tested this on a Void Linux system since I can't run mainline cinny-desktop on it (due to some libsoup/javascriptcore errors).
Fixes #398
Type of change
Checklist: