Skip to content

Conversation

@wizzeh
Copy link

@wizzeh wizzeh commented Nov 26, 2025

Description

Updates the Room Card to support MSC 2403. Cinny allows server admins to set rooms to knock only but doesn't allow users to actually make knocks. This PR is just a simple change to add knocking.

As a side effect we can also notify the user when a server is invite-only. This could be a separate PR if desired but I've wrapped it in here. The current behavior where you hit join and then get an error is confusing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [✓] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • [✓] My code follows the style guidelines of this project
  • [✓] I have performed a self-review of my own code
  • [✓] I have commented my code, particularly in hard-to-understand areas
  • [✓] I have made corresponding changes to the documentation
  • [✓] My changes generate no new warnings

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@wizzeh wizzeh force-pushed the ellie/improved-join branch from 931cb4f to 2fd20e5 Compare November 26, 2025 06:28
@wizzeh
Copy link
Author

wizzeh commented Nov 26, 2025

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant