Expand discipline choice to full ISO 19115 topic categories#484
Open
coltonbooth wants to merge 5 commits into
Open
Expand discipline choice to full ISO 19115 topic categories#484coltonbooth wants to merge 5 commits into
coltonbooth wants to merge 5 commits into
Conversation
|
Visit the preview URL for this PR (updated for commit 561dc82): https://cioos-metadata-form-dev-258dc--pr484-feature-expand-di-bgimvyrg.web.app (expires Thu, 16 Jul 2026 15:59:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9b6275cb4b6311b719349f5e25e457b5691d09c |
Member
|
In order to fully integrate this change, we will need to fix within the ISO-19115-3 xml output generated by the form this specific field which is right always defaulting to add the category oceans: TODO
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MD_TopicCategoryCodevalues, each with bilingual titles and definitionsnormalizeResourceType) to transparently map legacyoceanographic/biologicalvalues to their ISO equivalents (oceans/biota) in existingrecords
Changes
src/utils/themes.js— Replaced simple theme list with a structuredtopicCategoriesobject (22 ISO codes + "other") including en/fr titles, definitions, and aprominentflag
src/utils/normalizeResourceType.js— New utility to normalize legacy resource type values to ISO codessrc/components/Tabs/StartTab.jsx— Reworked the theme selector UI with prominent/non-prominent split and accordionsrc/utils/validate.js,MapSelect.jsx,IdentificationTab.jsx— Updated to use normalizer instead of hardcoded string checkssrc/utils/blankRecord.js— Default resource type set to["oceans"]src/categoryList.js— Removed (consolidated intothemes.js)normalizeResourceTypeand expandedvalidatetests for legacy/ISO compatibilityTest plan
oceanographic/biologicalvalues and confirm they display correctly as Oceans/Biotanpm test— all new and existing tests pass