Repository navigation
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00de4046ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # #243 GHSA-68fv-2mgg-jv7q / CVE-2026-93749 — source-map-js >=1.0.0 <1.2.2, | ||
| # patched 1.2.2 (published 2026-09-30). Reached through postcss and magicast, | ||
| # both of which declare ^1.x, so the pin is in range for every consumer. | ||
| 'source-map-js@<1.2.2': '1.2.2' |
There was a problem hiding this comment.
Scope the override to the actual vulnerable range
The advisory range documented immediately above starts at 1.0.0, but this selector also matches every 0.x release. If a current or future dependency requests a 0.x version, pnpm will rewrite it across a major-version boundary to 1.2.2 even though that release is not vulnerable, potentially breaking the consumer. Use source-map-js@>=1.0.0 <1.2.2 so the security override is limited to the stated affected range, as required by the repository's dependency-policy guidance.
AGENTS.md reference: AGENTS.md:L813-L813
Useful? React with 👍 / 👎.
Summary
Fixes Dependabot alert #243: GHSA-68fv-2mgg-jv7q / CVE-2026-93749 in
source-map-js(affected>=1.0.0 <1.2.2, patched in1.2.2).source-map-jsis transitive only, reached throughpostcssandmagicast. Open group PR #1136 moves one path but leavessource-map-js@1.2.1inpnpm-lock.yaml. This PR removes every vulnerable copy.Changes
pnpm-workspace.yaml: adds a scoped override'source-map-js@<1.2.2': '1.2.2'. It follows the existing overrides convention, with the ceiling set at the pin so the selector can't be overtaken.pnpm-lock.yaml:source-map-js1.2.1 -> 1.2.2 (the override entry, the package entry and both consumer snapshots). No other packages change.1.2.2 was published 2026-09-30, so it's past the 7-day
minimumReleaseAge.Verification
pnpm install --frozen-lockfilesucceeds and makes no changes to the lockfile.pnpm why -r source-map-jsreports one version:1.2.2. No<1.2.2copy remains in the lockfile.e2e/tests/supply-chain.e2e.test.tspasses (28/28).SourceMapGenerator->SourceMapConsumerround trip, andpostcsssource-map generation.Summary by CodeRabbit