Skip to content

fix(deps): patch rustls to 0.23.45 - #1158

Open
tobyhede wants to merge 1 commit into
mainfrom
fix/cip-4891-rustls
Open

tobyhede wants to merge 1 commit into
mainfrom
fix/cip-4891-rustls

Conversation

@tobyhede

Copy link
Copy Markdown
Contributor

Patches rustls to 0.23.45 to address GHSA-2mjx-qc3c-rqvc (RUSTSEC-2026-0285; affects >= 0.23.13, < 0.23.45).

Lockfile-only change via cargo update -p rustls --precise 0.23.45 in each workspace:

Cargo.lock rustls before after
Cargo.lock 0.23.36 0.23.45
packages/eql/Cargo.lock 0.23.40 0.23.45
languages/typescript/packages/protect-ffi/Cargo.lock 0.23.37 0.23.45
packages/stack-auth/fuzz/Cargo.lock 0.23.36 0.23.45

Required transitive bumps (rustls 0.23.45 needs rustls-webpki ^0.103.14 and aws-lc-rs ^1.18):

  • rustls-webpki 0.103.13 -> 0.103.15 (all four)
  • aws-lc-rs -> 1.18.1 and aws-lc-sys -> 0.45.0 (eql, protect-ffi; protect-ffi also gains pkg-config as an aws-lc-sys build dep)

Resolves Dependabot alerts #230, #234, #235, #239.

Verified locally with cargo check --locked (Rust 1.94.1) in all four workspaces.

Addresses GHSA-2mjx-qc3c-rqvc (RUSTSEC-2026-0285) in all four Cargo.lock files. rustls 0.23.45 requires aws-lc-rs ^1.18 and rustls-webpki ^0.103.14, so those move too where needed.
@tobyhede
tobyhede requested a review from a team as a code owner October 12, 2026 01:13
@changeset-bot

changeset-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 49314ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (4)
  • Cargo.lock is excluded by !**/*.lock
  • languages/typescript/packages/protect-ffi/Cargo.lock is excluded by !**/*.lock
  • packages/eql/Cargo.lock is excluded by !**/*.lock
  • packages/stack-auth/fuzz/Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 9f2d8138-0ac6-4b3c-92a0-0b758694371d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T01:17:23.021662Z 49314ad PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing (cargo-mutants, --in-diff, stack-auth + stack-encrypt)

No mutants were generated for the changed lines.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 49314ad9dd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[[package]]
name = "rustls"
version = "0.23.37"
version = "0.23.45"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add a changeset for the patched protect-ffi binaries

This lockfile determines the Rust compiled into the native and WASM @cipherstash/protect-ffi artifacts, but the commit adds no protect-ffi changeset. If the currently pending unrelated changeset is consumed before this commit lands, the committed package version will already exist on npm, so release.yml will skip rebuilding and publishing these artifacts and the rustls security fix will remain unreleased until some later bump. Add a patch changeset for the protect-ffi fixed package group rather than relying on unrelated release work.

AGENTS.md reference: AGENTS.md:L199-L207

Useful? React with 👍 / 👎.

Comment thread Cargo.lock
[[package]]
name = "rustls"
version = "0.23.36"
version = "0.23.45"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add an auth changeset for the root lockfile patch

The root lockfile's rustls is reached through stack-auth and compiled into stack-auth-node, so this changes what the published @cipherstash/auth platform binaries contain. Because the commit adds no auth changeset—and the auth changeset guard does not watch the root Cargo.lock—the patched binaries are not guaranteed a new version if the unrelated pending auth changesets are consumed first. Add an @cipherstash/auth patch changeset so this security remediation is released and recorded.

AGENTS.md reference: AGENTS.md:L93-L94

Useful? React with 👍 / 👎.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant