Repository navigation
Conversation
The CI workspace moved to crn:us-east-1.aws:EXRSSGWBYTIXCXWK. Its access key was issued by the ap-southeast-2 CTS, but with no CS_CTS_HOST the client derives the CTS host from the CRN's region and asks the us-east-1 CTS, which answers "401 Unknown credential" for a valid key. Every credentialed job has failed on auth since the move. Every job that passes vars.CS_WORKSPACE_CRN now also passes vars.CS_CTS_HOST and vars.CS_ZEROKMS_HOST, the same way proxy CI pins them. The Go live suite gets them as STACK_ENCRYPT_TEST_CTS_HOST and STACK_ENCRYPT_TEST_ZEROKMS_URL, because its cleanEnv clears CS_CTS_HOST. The e2e-tests job's hardcoded ap-southeast-2 pair is replaced: its ZeroKMS half pointed at the wrong region for this workspace. scripts/__tests__/cs-hosts-pinned.test.mjs fails on a job that carries the CRN without both host variables, and on any literal host URL.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every CI job that talks to the live CipherStash service has failed on authentication since the CI workspace moved to
crn:us-east-1.aws:EXRSSGWBYTIXCXWK, with401 Unauthorized: Authorization failed: Unknown credential id=Some("ZHWW54P57PJOIP6E"). The access key is valid, but it was issued by the ap-southeast-2 CTS (CipherStash's token service). With noCS_CTS_HOSTset, the client works out the CTS host from the CRN's region and asks the us-east-1 CTS, which has never seen the key. This PR passes both service hosts explicitly from new repo variables, the same way proxy CI does.Changes
vars.CS_WORKSPACE_CRNnow also passesCS_CTS_HOST: ${{ vars.CS_CTS_HOST }}andCS_ZEROKMS_HOST: ${{ vars.CS_ZEROKMS_HOST }}, in the same form the job already uses for the CRN (a jobenv:map, a stepenv:map, or a.envfile written by arun:step).tests-golang.yml): also passSTACK_ENCRYPT_TEST_CTS_HOSTandSTACK_ENCRYPT_TEST_ZEROKMS_URL.TestLiveAutoCredentialsFromTheEnvironmentclearsCS_CTS_HOSTand only restores it from those names.tests.ymle2e-tests: the hardcoded ap-southeast-2 pair is replaced. Its ZeroKMS half pointed at the wrong region for this workspace.integration-protect-ffi.yml: the comment explaining why the hosts were deliberately not set is rewritten, because this PR reverses that decision.scripts/__tests__/cs-hosts-pinned.test.mjs: fails if a job carries the CRN without both host variables, or if any workflow hardcodes a CTS or ZeroKMS URL.Verification
pnpm exec vitest run --config scripts/vitest.config.mjs: 76 files, 1368 tests passed (29 skipped).CS_CTS_HOST=https://ap-southeast-2.aws.cts.cipherstashmanaged.net,CS_ZEROKMS_HOST=https://us-east-1.aws.zerokms.cipherstashmanaged.net.Review notes
Merging this does not finish the workspace move. Still outstanding, outside this PR:
CLERK_MACHINE_TOKENandCLERK_MACHINE_TOKEN_B(dated 2026-10-12) are rejected by Clerk, so lock-context suites fail on every Dependabot PR. They need the Actions-store values.SELECTOR(tests/sqlx/src/fixtures/v3_doc_integer.rs) andSEL_HELLO_OP(tests/sqlx/src/fixtures/v3_ste_vec.rs) are keyed to the workspace keyset and need re-pinning from the candidates their drift guards print.cts-common'sCtsServiceDiscovery::endpointgives customers the wrong host too.No changeset: CI configuration and a repo-tooling test only.