Repository navigation
Conversation
Test EQL has a selector job, and the other pull request workflows are getting one each. Each workflow's selector must follow the same rules: no path filter on pull_request, one dorny/paths-filter step, an output named after each filter, every job selected on other events, a failure when a filter gives no answer, `if:` conditions that exclude pull_request, and a summary job that needs every other job. workflow-selectors.test.mjs checks those rules for every workflow that has a selector job, found by scanning. It runs the selector's own decision script and the summary job's own check. lib/selector.mjs holds the shared code. It reads a selector job, runs its script, and works out which jobs a pull request runs from the files it changes. It reads dorny's `every` quantifier and brace patterns, which a filter needs to exclude documentation. The parity test now compares a selector workflow's push paths with the union of its selector filters, by what each selects from the tracked files. That replaces Test EQL's written exemption. The dispatch test holds every selector output open, whatever its name.
Three guards check that a workflow's path filter covers what its jobs read: the binding build inputs, the auth binding sources, and the sources the integration suites import. They read `on.push.paths` and `on.pull_request.paths`. Once a workflow has a selector job, its pull request list moves into the selector filter of each job, and those guards would stop checking it. They now read, per job, the lists that decide whether that job runs: the workflow's push and pull_request lists, and the selector filter the job reads. For a workflow without a selector job this is the same two lists as before. They also check only the jobs that build or load the binding, not every job in the workflow.
Tests (Go) used a workflow-level path filter on pull_request. A workflow that a path filter skips leaves its required checks pending, and GitHub's documentation on required status checks says that blocks a merge. The workflow now runs on every pull request. A `selector` job on a GitHub-hosted runner decides which jobs run, and fails when a filter gives no answer. A `Tests (Go) summary` job ends the workflow, and passes when every needed job passed or was skipped. wasi-check keeps the old filter's paths. go-binding-cross and live need it, so they run when it runs. go-lint gets its own filter: the Go module and mise.toml, which pins go and golangci-lint. It needs no guests, so a change to a stack crate alone no longer lints the Go module. Markdown and `.example` files are still excluded, through dorny's `every` quantifier. The push list is unchanged, and matches the union of the two filters. golang-selector.test.mjs pins what the selector decides.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This was referenced Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests (Go) checks the Go module and the WASI guests it embeds. It used a workflow-level path filter, so it did not start at all on most pull requests. A workflow skipped that way leaves its required checks pending, and GitHub's documentation on required status checks says that blocks a merge.
After this change, Tests (Go) starts on every pull request. A selector job decides which of its jobs run, and a summary job reports the result. The Go lint no longer runs for a change to a stack crate alone.
This pull request is stacked on #1417. Merge that one first.
Changes
tests-golang.yml, onubuntu-latest. It has two filters:gofor the guest jobs, andgo_lintfor the lint. It fails when a filter gives no answer on a pull request.gofilter: the old filter's paths.wasi-checkreads it.go-binding-crossandliveneedwasi-check, so they run when it runs.go_lintfilter:languages/golang/**,mise.toml, and the workflow file.mise.tomlpinsgoandgolangci-lint. The lint needs no guests..examplefiles. They use dorny'severyquantifier for that.Tests (Go) summaryneeds every other job. It passes when each passed or was skipped.golang-selector.test.mjspins what the selector decides.Verification
pnpm run test:scripts: 83 files, 1,461 tests passed, 3 skipped.actionlint1.7.12 withshellcheck0.11.0 ontests-golang.yml: no findings.go:lintmise task. It runsgolangci-lint run ./...inlanguages/golang. The workflow comment says the packages compile without the guests.tests-golang.yml, so every job runs here.Related
Review notes
go_lintfilter.go-binding-crossandlivedo not read the selector. They are skipped whenwasi-checkis skipped.