Repository navigation
Conversation
The description was an unquoted YAML scalar containing ": " ("...guards
that break installs: command-time ceilings..."), which is invalid — a
plain scalar can't hold a colon-space. Every consumer that parses the
frontmatter throws on it.
cipherstash.com mirrors these skills at build time via the marketing
app's prebuild step, so this took down that site's deploys on every
branch, not just the one that touched skills.
Rewrites the value as a folded block scalar, which handles both the
colons and the embedded double quotes. The parsed string is byte-for-byte
what it was.
Closes CIP-3900
Claude-Session: https://claude.ai/code/session_01HnNBVu5xeEQ8AdVgLxkKWL
🦋 Changeset detectedLatest commit: bd7e55f The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
freshtonic
left a comment
freshtonic
left a comment
There was a problem hiding this comment.
One thing blocks this, and it's small: it needs a stash patch changeset.
Everything substantive verified:
- The bug is real: parsing main's frontmatter with js-yaml fails ("bad indentation of a mapping entry (3:856)") — the unquoted
installs: command-timecolon-space, exactly as described. - The
>-folded scalar parses, and the parseddescriptionis byte-for-byte identical to the old raw line (I diffed them programmatically). The body is untouched. - CI is green.
But skills/ ships inside the stash npm tarball, and AGENTS.md is explicit that a skills-only change is not internal — it needs a stash patch changeset (changeset-bot flagged this too). Without one, the currently published tarball keeps shipping the unparseable frontmatter to every stash init and the fix only ever reaches the marketing site's main-branch mirror. The changeset is what makes this fix ship.
Suggested text:
---
'stash': patch
---
Fix invalid YAML in `skills/stash-managed-platforms/SKILL.md` frontmatter: the
unquoted `description` contained a colon-space, so any YAML parser rejected the
file (this broke cipherstash.com deploys, which mirror these skills at build
time). Rewritten as a folded block scalar; the parsed description is
byte-for-byte identical.
Add that and this is an insta-approve.
One heads-up, not blocking: #951 edits this same file's body (managed-platforms snippet + the "three things" list) — frontmatter vs body, so no textual conflict expected, but whichever merges second should double-check the rebase.
managed-platforms frontmatter fix
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe skill description was reformatted as a folded YAML block. A patch changeset records the update and states that the parsed description remains unchanged. ChangesSkill frontmatter formatting
Priority: ⬆️ High Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The skill description now parses without changing its intended text. The patch changeset targets the package that ships the skill; the PR is ready to merge after normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
This branch has not been deployed
2 participants
skills/stash-managed-platforms/SKILL.mdhas an unquoteddescription:containing::A plain YAML scalar can't hold a colon-space, so anything parsing this frontmatter throws:
cipherstash.com mirrors these skills at build time (the marketing app's
prebuildrunsgenerate-agent-skills.mjsagainstcipherstash/stack@main), so this broke that site's deploys on every branch, not only ones touching skills. It surfaced on an unrelated dashboard PR.Rewritten as a folded block scalar (
>-), which is safe for both the colons and the embedded"version too new"quotes. The parsed string is byte-for-byte identical to before — verified against the currentmainfile:All 14 skills now parse;
stash-managed-platformswas the only broken one.Closes CIP-3900
https://claude.ai/code/session_01HnNBVu5xeEQ8AdVgLxkKWL
Summary by CodeRabbit