refactor(cross-chain): execute.ts を protocol 別の executor と burn 回復に分割し facade を維持 (R12・掟 15) - #619
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
…し facade を維持 (R12・掟 15) 第 6 回レビュー Phase 6 の R12 (F14)。1,542 行の lib/crossChain/execute.ts を 54 行の facade (同じ export と path) と executeTypes/executeErrors/executeShared/burnRecovery/ executeGateway/executeCctp/executeForward に分ける。36 個の宣言は byte 単位で同一。 error class は 1 か所で定義し facade と内部で同一性を保つ。runtime import に循環なし (forward は cctp を import しない)・module 単位の状態なし・deploycheck の cache は 1 つ。 内部 module を lib/crossChain の外から直接 import することはテストで禁止する。 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HeizmagJBgL5peL5mQpxkc
cipherwebllc
force-pushed
the
fix/r6-r12-crosschain-split
branch
from
September 24, 2026 13:14
0eb8ff9 to
832bf91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
第 6 回レビュー Phase 6 (完全リファクタ) の R12 です (指摘 F14)。挙動を変えない抽出だけです。
1,542 行の
lib/crossChain/execute.ts(Circle Gateway・CCTP v2・forwarding による cross-chain の USDC 支払い) を、54 行の facade (同じ export と module path) と 7 つの module に分けます。executeTypes.tsexecuteErrors.tsexecuteShared.tsburnRecovery.tsreadBurnReceiptState・resolveBurnSlot・assertBurnResolved・settleBurn)executeGateway.tsexecuteCctp.tsexecuteForward.tsexport {…}だけです。instanceofは従来どおり)。CrossChainHintからだけ到達します。初回ロードの bundle は main と同じです。lib/crossChainの外から直接 import すると入口の検査を飛ばせるため、テストで禁止しました。固定と検証 (base = main に rebase 済み)
見つかった既存の事項 (本 PR では変えない)
settleMintは main の時点で到達しない関数です (そのまま移動・別 PR で削除)。🤖 Generated with Claude Code
https://claude.ai/code/session_01HeizmagJBgL5peL5mQpxkc