fix(qr): QR modal が親の再描画ごとに focus を奪う・金額欄がモード切替で作り直される等を直す (B-R11d) - #635
Open
cipherwebllc wants to merge 1 commit into
Open
cipherwebllc wants to merge 1 commit into
cipherwebllc wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
第 6 回レビュー R11b で固定した QR 生成画面の既存の挙動 4 件。(1) プレビュー modal の onClose が render ごとに変わり dialog に focus が戻っていた → handler を安定化 (open 時の focus と Escape は従来どおり)。(2) 下部 bar の再描画 effect が初回表示で発火しなかった → 表示状態を依存に加える。(3) 据え置き↔金額指定の切替で金額入力と quick-amount editor が 作り直されていた → 既存 root に hidden を付けて node と入力値を保つ。据え置き → 金額指定の 切替では従来どおり金額欄に focus する (flushSync + ref)。(4) FX の期限切れは注意表示のみの 既存方針を維持 (comment に明記)。支払い URL・EIP-681・receipt の fixture は不変。 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HeizmagJBgL5peL5mQpxkc
cipherwebllc
force-pushed
the
fix/r6-b11d-qr-modal-focus
branch
from
September 24, 2026 22:23
47c8252 to
31f2f8e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
第 6 回レビュー R11b (#618) で固定した QR 生成画面の既存の挙動 4 件の修正 (B-R11d) です。意図的な挙動変更 (UX) です。
onCloseの識別を安定化。開いたときの focus と Escape での閉じ方は従来どおりhiddenを付けて node を保つ (wrapper の追加なし)。据え置き → 金額指定では従来どおり金額欄に focus する (iOS で keyboard が開く)hiddenの入力欄は読まれません)。hiddenを付けた 2 要素に Tailwind の display class はなく、tab 順・読み上げ・印刷からも外れます。検証
同種の既存問題 (別 PR・B-R11e)
レジの QR modal (RegisterMode) と CSV パスの modal にも同じ focus 奪取があります。modal 側で直せば全呼び出しに効くので、別 PR にします。modal が閉じるときに focus を戻さない・focus trap がない点も既存のままです。
🤖 Generated with Claude Code
https://claude.ai/code/session_01HeizmagJBgL5peL5mQpxkc