Skip to content

fix(m365): Correct issues when specifying input_storage_container_url#31

Merged
jacdavi merged 2 commits intomainfrom
fix/input_storage
Apr 20, 2026
Merged

fix(m365): Correct issues when specifying input_storage_container_url#31
jacdavi merged 2 commits intomainfrom
fix/input_storage

Conversation

@jacdavi
Copy link
Copy Markdown
Collaborator

@jacdavi jacdavi commented Apr 20, 2026

🗣 Description

  • Fix Terraform attempting to upload tenant files when input_storage_container_url is specified
  • Fix output variable for input_storage_container_url being set incorrectly
  • Updates variable descriptions to provide more clarity on how to set input_storage_container_url
    • Update tf_vars_to_adoc.py helper script to support version 8+ python-hcl2

💭 Motivation and context

Closes #30

🧪 Testing

Verified successful deployment with a separate input container

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

jacdavi added 2 commits April 20, 2026 14:24
…ntainer urls

update tf_vars_to_adoc to support version 8+ of hcl2 library
@jacdavi jacdavi merged commit ad3c1db into main Apr 20, 2026
7 checks passed
@jacdavi jacdavi deleted the fix/input_storage branch April 20, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[m365] variable input_storage_container_url not functional

1 participant