Add directions for enrolling cisagov repositories in Lineage updates#66
Open
Add directions for enrolling cisagov repositories in Lineage updates#66
cisagov repositories in Lineage updates#66Conversation
Add instructions on configuring a cisagov repository to receive automatic updates.
mcdonnnj
added
documentation
jsf9k
approved these changes
Feb 24, 2023
dav3r
approved these changes
Feb 24, 2023
Member
dav3r
left a comment
dav3r
left a comment
There was a problem hiding this comment.
LGTM with one small take-it-or-leave-it suggestion. 👍
Clarify that a repository should be based on any publicly accessible parent and offer the `cisagov` skeleton repositories as options. Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
jsf9k
approved these changes
Feb 24, 2023
Member
jsf9k
left a comment
jsf9k
left a comment
There was a problem hiding this comment.
I left a couple of extremely minor suggestions, but I still approve this PR whether you take them or leave them.
Comment on lines
+45
to
+48
| 1. Ensure your project is based on a publicly accessible parent repository | ||
| (such as a [`cisagov` skeleton repository](https://github.com/cisagov/development-guide/blob/develop/project_setup/skeleton-list.md)) | ||
| 1. Provide [`write`](https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/repository-roles-for-an-organization#repository-roles-for-organizations) | ||
| access to [@cisagovbot](https://github.com/cisagovbot) or [@cisagov/team-ois](https://github.com/orgs/cisagov/teams/team-ois) |
Member
There was a problem hiding this comment.
Personally, I'd add periods to the end of these since they are complete sentences. Take it or leave it.
Suggested change
| 1. Ensure your project is based on a publicly accessible parent repository | |
| (such as a [`cisagov` skeleton repository](https://github.com/cisagov/development-guide/blob/develop/project_setup/skeleton-list.md)) | |
| 1. Provide [`write`](https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/repository-roles-for-an-organization#repository-roles-for-organizations) | |
| access to [@cisagovbot](https://github.com/cisagovbot) or [@cisagov/team-ois](https://github.com/orgs/cisagov/teams/team-ois) | |
| 1. Ensure your project is based on a publicly accessible parent repository | |
| (such as a [`cisagov` skeleton repository](https://github.com/cisagov/development-guide/blob/develop/project_setup/skeleton-list.md)). | |
| 1. Provide [`write`](https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/repository-roles-for-an-organization#repository-roles-for-organizations) | |
| access to [@cisagovbot](https://github.com/cisagovbot) or [@cisagov/team-ois](https://github.com/orgs/cisagov/teams/team-ois). |
| access to [@cisagovbot](https://github.com/cisagovbot) or [@cisagov/team-ois](https://github.com/orgs/cisagov/teams/team-ois) | ||
|
|
||
| Once these changes are implemented your repository should see new pull requests | ||
| generated as appropriate during the regular Lineage organization checks. |
Member
There was a problem hiding this comment.
Just a suggestion. Take it or leave it; it does not impact my approval.
Suggested change
| generated as appropriate during the regular Lineage organization checks. | |
| generated when appropriate during the regular Lineage organization checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the README to add directions to enable Lineage updates for repositories with maintainers outside of our group.
💭 Motivation and context
This will help any other members of the
cisagovorg get these automatic updates in their repositories if they so desire.🧪 Testing
Automated tests pass.
✅ Pre-approval checklist
to reflect the changes in this PR.