⚠️ CONFLICT! Lineage pull request for: skeleton#11
Open
cisagovbot wants to merge 70 commits intodevelopfrom
Open
⚠️ CONFLICT! Lineage pull request for: skeleton#11cisagovbot wants to merge 70 commits intodevelopfrom
cisagovbot wants to merge 70 commits intodevelopfrom
Conversation
Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
The `pull_request` trigger's default activity types are `opened`, `reopened`, and `synchronized`. These types better represent when we want this workflow to run and the `edited` type was resulting in undesired workflow runs.
This is done automatically with the `pre-commit autoupdate` command.
The latest release supports the artifact-metadata permission that we are now using in the generate-sbom job of the build.yml GitHub Actions workflow in cisagov/skeleton-aws-lambda-python, cisagov/skeleton-docker, and cisagov/skeleton-python-library.
This will return the cache key to being a string with no new lines.
It is no longer necessary to install wheel alongside setuptools as of setuptools v70.1: https://github.com/pypa/wheel?tab=readme-ov-file#historical-note
This is done automatically with the pre-commit autoupdate command.
We rely on the default activity types for the pull_request event in our GitHub Actions workflows. This adds a comment mentioning that we do so and linking to the GitHub documentation for the event which details the specific activity types that are used by default. Co-authored-by: dav3r <david.redmin@gwe.cisa.dhs.gov>
This is done automatically with the pre-commit autoupdate command.
Remove installation of `wheel` Python package
…s/cache-5 Bump actions/cache from 4 to 5
…ggers Adjust the activity types for the `pull_request` trigger in the `Label pull requests` workflow
…ting Adjust the `lint` job of the `build` workflow's cache key formatting
Update `pre-commit` hook versions
Now that I have two pull requests out for changes relevant to our work it makes sense to use a branch that consolidates any changes we need.
It is no longer necessary to install wheel alongside setuptools as of setuptools v70.1.
We need to update the comment about using a branch of mcdonnnj's terraform-docs fork to reflect that a second PR with different functionality is now included in the branch. Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
…s_branch Change the branch we use for installing terraform-docs
Bumps [crazy-max/ghaction-github-labeler](https://github.com/crazy-max/ghaction-github-labeler) from 5 to 6. - [Release notes](https://github.com/crazy-max/ghaction-github-labeler/releases) - [Commits](crazy-max/ghaction-github-labeler@v5...v6) --- updated-dependencies: - dependency-name: crazy-max/ghaction-github-labeler dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [hashicorp/setup-terraform](https://github.com/hashicorp/setup-terraform) from 3 to 4. - [Release notes](https://github.com/hashicorp/setup-terraform/releases) - [Changelog](https://github.com/hashicorp/setup-terraform/blob/main/CHANGELOG.md) - [Commits](hashicorp/setup-terraform@v3...v4) --- updated-dependencies: - dependency-name: hashicorp/setup-terraform dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This warning contradicts the Black style so it must be ignored.
Make the ignore commenting consistent with the select commenting. Break up each comment/directive with an empty line.
This adds the flake8-bugbear plugin to our pre-commit configuration. Note that flake8 is already configured to use this plugin's warnings.
Add the dlint plugin to our flake8 configuration for pre-commit. Update the flake8 configuration to select these new warnings.
Add the flake8-noqa plugin to the flake8 portion of our pre-commit configuration. Update the flake8 configuration to select these new warnings.
Coverage Report for CI Build 25198131969Coverage remained the same at 100.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This gets rid of an error from our flake8 pre-commit linter.
This gets rid of some errors from our flake8 pre-commit linter.
jsf9k
approved these changes
May 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR brings this repository back in sync with the upstream skeleton-python-library template, primarily updating developer tooling and CI configuration while making small formatting-only adjustments in a few Python/test files.
Changes:
- Updates CI workflows (job naming, caching keys, action versions) and Dependabot grouping/ignore settings.
- Refreshes pre-commit hook versions and expands Flake8 plugin configuration in
pyproject.toml. - Applies line-wrapping/formatting tweaks in tests and logging filter code.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_log_filters.py |
Wraps long test strings for lint/formatting compliance. |
src/cyhy_logging/log_filters.py |
Wraps docstrings/comments and refactors a long f-string into a parenthesized return. |
src/cyhy_logging/__init__.py |
Adjusts Flake8 suppression comments/markers around __version__ import. |
setup-env |
Stops upgrading/installing wheel during environment setup. |
requirements.txt |
Updates guidance comment to reference pyproject.toml dependencies; removes wheel requirement. |
pyproject.toml |
Expands Flake8 configuration (more selected code families, updated ignore commentary). |
.pre-commit-config.yaml |
Bumps hook versions and adds Flake8 plugin dependencies; extends pip-audit args. |
.github/workflows/sync-labels.yml |
Updates label sync action major version. |
.github/workflows/label-prs.yml |
Uses default pull_request activity types; adds explanatory comment. |
.github/workflows/dependency-review.yml |
Adds comment noting default pull_request activity types. |
.github/workflows/codeql-analysis.yml |
Adds comment noting default pull_request activity types. |
.github/workflows/build.yml |
Updates caching/action versions, renames jobs, adjusts cache keys and build/test flow. |
.github/dependabot.yml |
Adds grouping for upload/download-artifact and expands ignored pip dependencies. |
Comments suppressed due to low confidence (1)
src/cyhy_logging/log_filters.py:62
logging.Filter.filter()is expected to return a boolean; the logging framework ignores any returnedLogRecord. Because this implementation copies the record and returns the copy, the handler will continue emitting the original (unredacted) record when this filter is attached viahandler.addFilter(...)(as done insetup_logging). Update the filter to mutaterecord.msg/record.argsin place (or otherwise ensure the emitted record is modified) and returnTrue, and adjust the return type/docstring/tests accordingly.
# Create a shallow copy of the record only if modification is needed
new_record = copy.copy(record)
# Update the message and clear args since we are directly
# setting the final message
new_record.msg = redacted_message
new_record.args = None
return new_record
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
|
|
||
| from ._version import __version__ # noqa: F401, E402 | ||
| from ._version import __version__ # noqa: E402 |
Member
There was a problem hiding this comment.
The presence of # noqa: F401 was precisely what flake8 complained about, which led me to make the change.
| key: >- | ||
| ${{ env.BASE_CACHE_KEY }}${{ | ||
| hashFiles('**/requirements-test.txt') }}-${{ | ||
| hashFiles('**/requirements.txt') }}${{ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lineage Pull Request: CONFLICT
Lineage has created this pull request to incorporate new changes found in an upstream repository:
Upstream repository:
https://github.com/cisagov/skeleton-python-library.gitRemote branch:
HEADCheck the changes in this pull request to ensure they won't cause issues with your project.
The
lineage/skeletonbranch has one or more unresolved merge conflicts that you must resolve before merging this pull request!How to resolve the conflicts
Take ownership of this pull request by removing any other assignees.
Clone the repository locally, and reapply the merge:
Review the changes displayed by the
statuscommand. Fix any conflicts and possibly incorrect auto-merges.After resolving each of the conflicts,
addyour changes to the branch,commit, andpushyour changes:Note that you may append to the default merge commit message that git creates for you, but please do not delete the existing content. It provides useful information about the merge that is being performed.
Wait for all the automated tests to pass.
Confirm each item in the "Pre-approval checklist" below.
Remove any of the checklist items that do not apply.
Ensure every remaining checkbox has been checked.
Mark this draft pull request "Ready for review".
✅ Pre-approval checklist
Note
You are seeing this because one of this repository's maintainers has configured Lineage to open pull requests.
For more information:
🛠 Lineage configurations for this project are stored in
.github/lineage.yml📚 Read more about Lineage