Lineage pull request for: skeleton by cisagovbot · Pull Request #124 · cisagov/development-guide

cisagovbot · 2026-03-26T01:22:41Z

Lineage Pull Request

Lineage has created this pull request to incorporate new changes found in an upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-generic.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with your project.

✅ Pre-approval checklist

All future TODOs are captured in issues, which are referenced in code comments.
All relevant type-of-change labels have been added.
All new and existing tests pass.
Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.

✅ Pre-merge checklist

Finalize version.

✅ Post-merge checklist

Create a release (necessary if and only if the version was bumped).

Note

You are seeing this because one of this repository's maintainers has configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

Bumps [crazy-max/ghaction-github-labeler](https://github.com/crazy-max/ghaction-github-labeler) from 5 to 6. - [Release notes](https://github.com/crazy-max/ghaction-github-labeler/releases) - [Commits](crazy-max/ghaction-github-labeler@v5...v6) --- updated-dependencies: - dependency-name: crazy-max/ghaction-github-labeler dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [hashicorp/setup-terraform](https://github.com/hashicorp/setup-terraform) from 3 to 4. - [Release notes](https://github.com/hashicorp/setup-terraform/releases) - [Changelog](https://github.com/hashicorp/setup-terraform/blob/main/CHANGELOG.md) - [Commits](hashicorp/setup-terraform@v3...v4) --- updated-dependencies: - dependency-name: hashicorp/setup-terraform dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

This warning contradicts the Black style so it must be ignored.

Make the ignore commenting consistent with the select commenting. Break up each comment/directive with an empty line.

This adds the flake8-bugbear plugin to our pre-commit configuration. Note that flake8 is already configured to use this plugin's warnings.

Add the dlint plugin to our flake8 configuration for pre-commit. Update the flake8 configuration to select these new warnings.

Add the flake8-noqa plugin to the flake8 portion of our pre-commit configuration. Update the flake8 configuration to select these new warnings.

Add the pep8-naming plugin to the flake8 portion of our pre-commit configuration. Update the flake8 configuration to select these new warnings.

Add the flake8-comprehensions plugin to the flake8 portion of our pre-commit configuration. Update the flake8 configuration to select these new warnings.

When explaining the items selected or ignored in the configuration we now preface each line with the prefix/code it pertains to in the configuration. Also break apart the pycodestyle prefixes into their own lines.

The `go-critic` pre-commit hook from the TekWizely/pre-commit-golang repo expects the binary to be called `go-critic` now. As a result, the current tool installation in the `build.yml` workflow results in the following error when pre-commit is run in GitHub Actions: error: command not found: go-critic

The file is not used to configure anything bandit does by default so we can safely remove it and updated the pre-commit configuration. This is also acceptable because the configuration file has been removed downstream in cisagov/skeleton-python-library already.

Change two reference URLs in the flake8 configuration to use `https://` instead of `http://`. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Change a reference URL in the flake8 configuration because `pydocstyle.org` domain ownership appears to have lapsed. Instead point to the source file in the archived GitHub repository. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Attribute the error codes we are ignoring to the correct source package. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

This extends our usage of the antonbabenko/pre-commit-terraform hook collection. This new hook will automatically ensure that a Terraform lock file includes hashes for all of our supported platforms.

We have to ignore this vulnerability for now since an update for pygments has not yet been released. In any event, this vulnerability is unlikely to cause us any problems since we don't feed any regexes to pygments directly. See also: - cisagov/skeleton-generic#257 - https://nvd.nist.gov/vuln/detail/CVE-2026-4539 - pygments/pygments#3058 Co-authored-by: Nick M <50747025+mcdonnnj@users.noreply.github.com>

Ignore a vulnerability originating from `pygments`

…orp/setup-terraform-4 Bump hashicorp/setup-terraform from 3 to 4

…max/ghaction-github-labeler-6 Bump crazy-max/ghaction-github-labeler from 5 to 6

This is done automatically with the pre-commit autoupdate command.

Newer versions of the hook require Python 3.14, but we are still using Python 3.13 in our GitHub Actions configuration.

Install the `go-critic` command instead of `gocritic` in the `build.yml` workflow

…uration Add additional plugins to the `flake8` pre-commit configuration

…to_lock_terraform_providers Add a pre-commit hook to lock Terraform providers automatically

Update `pre-commit` hook versions

…uration_file Remove the bandit configuration file

Our flake8 pre-commit hook was giving errors for these scripts, but since they are no longer in use there is no reason to update them.

This gets rid of several errors from our flake8 pre-commit hook.

This gets rid of an error from our flake8 pre-commit hook.

dependabot bot and others added 29 commits March 2, 2026 20:23

Add E203 to ignore list for flake8

2c37bcc

This warning contradicts the Black style so it must be ignored.

Reformat .flake8 configuration

0f44a77

Make the ignore commenting consistent with the select commenting. Break up each comment/directive with an empty line.

Add the flake8-bugbear plugin

57ce573

This adds the flake8-bugbear plugin to our pre-commit configuration. Note that flake8 is already configured to use this plugin's warnings.

Add dlint plugin for flake8

d1356e9

Add the dlint plugin to our flake8 configuration for pre-commit. Update the flake8 configuration to select these new warnings.

Add the flake8-noqa plugin for flake8

0fd3256

Add the flake8-noqa plugin to the flake8 portion of our pre-commit configuration. Update the flake8 configuration to select these new warnings.

Add pep8-naming plugin for flake8

f3bf99f

Add the pep8-naming plugin to the flake8 portion of our pre-commit configuration. Update the flake8 configuration to select these new warnings.

Add flake8-comprehensions plugin for flake8

b1503a0

Add the flake8-comprehensions plugin to the flake8 portion of our pre-commit configuration. Update the flake8 configuration to select these new warnings.

Adjust flake8 configuration comment format

3056053

When explaining the items selected or ignored in the configuration we now preface each line with the prefix/code it pertains to in the configuration. Also break apart the pycodestyle prefixes into their own lines.

Use https:// instead of http:// in referenced URLs

175c410

Change two reference URLs in the flake8 configuration to use `https://` instead of `http://`. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update a reference URL

a2e2621

Change a reference URL in the flake8 configuration because `pydocstyle.org` domain ownership appears to have lapsed. Instead point to the source file in the archived GitHub repository. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update ignore comment in the flake8 configuration

c85cbef

Attribute the error codes we are ignoring to the correct source package. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Add pre-commit hook to lock Terraform providers automatically

f094a60

This extends our usage of the antonbabenko/pre-commit-terraform hook collection. This new hook will automatically ensure that a Terraform lock file includes hashes for all of our supported platforms.

Correct reference to ticket in TODO comment

a1cdc78

Merge pull request #258 from cisagov/ignore-pygments-vuln

71bbac4

Ignore a vulnerability originating from `pygments`

Merge pull request #252 from cisagov/dependabot/github_actions/hashic…

2f729bb

…orp/setup-terraform-4 Bump hashicorp/setup-terraform from 3 to 4

Merge pull request #251 from cisagov/dependabot/github_actions/crazy-…

391e54b

…max/ghaction-github-labeler-6 Bump crazy-max/ghaction-github-labeler from 5 to 6

Update pre-commit hook versions

811785c

This is done automatically with the pre-commit autoupdate command.

Revert version bump of the ansible-lint pre-commit hook

df57f2a

Newer versions of the hook require Python 3.14, but we are still using Python 3.13 in our GitHub Actions configuration.

Merge pull request #254 from cisagov/bug/adjust_gocritic_install

60c481a

Install the `go-critic` command instead of `gocritic` in the `build.yml` workflow

Merge pull request #255 from cisagov/improvement/update_flake8_config…

24bc1e0

…uration Add additional plugins to the `flake8` pre-commit configuration

Merge pull request #256 from cisagov/improvement/add_pre-commit_hook_…

5103fb6

…to_lock_terraform_providers Add a pre-commit hook to lock Terraform providers automatically

Merge pull request #259 from cisagov/maintenance/update_pre-commit_hooks

52df901

Update `pre-commit` hook versions

Merge pull request #253 from cisagov/improvement/remove_bandit_config…

72ac03a

…uration_file Remove the bandit configuration file

Merge https://github.com/cisagov/skeleton-generic into lineage/skeleton

09f90af

cisagovbot requested a review from dav3r as a code owner March 26, 2026 01:22

cisagovbot requested review from felddy, jsf9k and mcdonnnj as code owners March 26, 2026 01:22

cisagovbot assigned dav3r, felddy, jsf9k and mcdonnnj Mar 26, 2026

cisagovbot added the upstream update This issue or pull request pulls in upstream updates label Mar 26, 2026

github-actions bot added dependencies Pull requests that update a dependency file github-actions Pull requests that update GitHub Actions code test This issue or pull request adds or otherwise modifies test code labels Mar 26, 2026

jsf9k unassigned felddy, dav3r and mcdonnnj Mar 26, 2026

jsf9k added 3 commits March 26, 2026 10:25

Remove scripts that are no longer used

c55c9d2

Our flake8 pre-commit hook was giving errors for these scripts, but since they are no longer in use there is no reason to update them.

Prefer dict literals ({}) to dict()

68ea13a

This gets rid of several errors from our flake8 pre-commit hook.

Break up an overly long line

5e9c997

This gets rid of an error from our flake8 pre-commit hook.

github-actions bot added the python Pull requests that update Python code label Mar 26, 2026

Bump version from 1.0.0 to 1.1.0

0c15a8e

github-actions bot added the version bump This issue or pull request increments the version number label Mar 26, 2026

jsf9k approved these changes Mar 26, 2026

View reviewed changes

jsf9k enabled auto-merge March 26, 2026 14:39

dav3r approved these changes Mar 26, 2026

View reviewed changes

jsf9k merged commit a448a05 into develop Mar 26, 2026
13 checks passed

jsf9k deleted the lineage/skeleton branch March 26, 2026 15:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lineage pull request for: skeleton#124

Lineage pull request for: skeleton#124
jsf9k merged 33 commits intodevelopfrom
lineage/skeleton

cisagovbot commented Mar 26, 2026 •

edited by jsf9k

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

cisagovbot commented Mar 26, 2026 • edited by jsf9k Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lineage Pull Request

✅ Pre-approval checklist

✅ Pre-merge checklist

✅ Post-merge checklist

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cisagovbot commented Mar 26, 2026 •

edited by jsf9k

Loading