Skip to content

Use latest release of cisagov/guacscanner#42

Merged
jsf9k merged 12 commits intodevelopfrom
improvement/use-latest-guacscanner
Apr 29, 2026
Merged

Use latest release of cisagov/guacscanner#42
jsf9k merged 12 commits intodevelopfrom
improvement/use-latest-guacscanner

Conversation

@jsf9k
Copy link
Copy Markdown
Member

@jsf9k jsf9k commented Apr 22, 2026

🗣 Description

This pull request:

  • Updates Pipfile to use the latest release of cisagov/guacscanner
  • Relocks the Pipfile to update Pipfile.lock

See also:

💭 Motivation and context

The latest release of cisagov/guacscanner contains cisagov/guacscanner#269, which resolves cisagov/guacscanner#268.

🧪 Testing

All automated tests pass. I also deployed a new cisagov/guacamole-packer AMI with this change as part of the testing for cisagov/guacamole-packer#124 and verified that it functions as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.
  • Create a pre-release (necessary if and only if the pre-release version was bumped).

✅ Pre-merge checklist

✅ Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

@jsf9k jsf9k self-assigned this Apr 22, 2026
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Apr 22, 2026
@github-actions github-actions Bot added documentation This issue or pull request improves or adds to documentation version bump This issue or pull request increments the version number dependencies Pull requests that update a dependency file labels Apr 22, 2026
jsf9k added a commit to cisagov/guacamole-composition that referenced this pull request Apr 23, 2026
This is being done temporarily for testing purposes.  Once
cisagov/guacscanner-docker#42 is merged this version will be replaced
with a release version.
jsf9k added a commit to cisagov/guacamole-composition that referenced this pull request Apr 24, 2026
This is being done for testing purposes.  Once
cisagov/guacscanner-docker#42 is merged and a new release created we
can use the latest release.
jsf9k added a commit to cisagov/guacamole-composition that referenced this pull request Apr 24, 2026
This is being done for testing purposes.  Once
cisagov/guacscanner-docker#42 is merged and a new release created we
can use the latest release.
jsf9k added a commit to cisagov/guacamole-composition that referenced this pull request Apr 27, 2026
This is being done for testing purposes.  Once
cisagov/guacscanner-docker#42 is merged and a new release created we
can use the latest release.
jsf9k added a commit to cisagov/guacamole-composition that referenced this pull request Apr 28, 2026
This is being done for testing purposes.  Once
cisagov/guacscanner-docker#42 is merged and a new release created we
can use the latest release.
@jsf9k jsf9k marked this pull request as ready for review April 28, 2026 16:59
@jsf9k jsf9k requested a review from dav3r as a code owner April 28, 2026 16:59
Copilot AI review requested due to automatic review settings April 28, 2026 16:59
@jsf9k jsf9k requested review from felddy and mcdonnnj as code owners April 28, 2026 16:59
@jsf9k jsf9k requested a review from a team April 28, 2026 16:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Docker image’s packaged Python dependency cisagov/guacscanner and bumps the image version/documentation accordingly to align with the new dependency set.

Changes:

  • Bump image version from 1.2.1-rc.1 to 1.2.1-rc.6.
  • Update guacscanner dependency source to v3.0.1-rc.5 and re-lock dependencies.
  • Update README examples to reference the new image tag.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/Pipfile Pins guacscanner to a newer GitHub archive (RC) version.
src/Pipfile.lock Updates the locked dependency set/hashes after re-locking.
src/version.txt Updates the container/image version string.
README.md Updates usage examples and tag references to the new version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Pipfile Outdated
jsf9k added 2 commits April 29, 2026 13:27
This also necessitates relocking the Pipfile.

This is possible now that cisagov/guacscanner#269 has been merged and
a new release created.
@jsf9k jsf9k merged commit 595b2d0 into develop Apr 29, 2026
27 checks passed
@jsf9k jsf9k deleted the improvement/use-latest-guacscanner branch April 29, 2026 18:06
jsf9k added a commit to cisagov/guacamole-composition that referenced this pull request Apr 29, 2026
This can be done now that cisagov/guacscanner-docker#42 is merged and
a new release created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IPs not updated in Guacamole connections when they change

3 participants