chore(gitignore): unignore src/bin and remove unimportant files #865
chore(gitignore): unignore src/bin and remove unimportant files #865YoganshSharma wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThe ChangesGitignore Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| .idea | ||
| .ra-target | ||
| bin | ||
| !/src/bin |
There was a problem hiding this comment.
The bin in the above line is ignoring src/bin too.
this line unignores that
There was a problem hiding this comment.
Ah I see. In that case, we should just add the /bin pattern. instead of adding a ! of /src/bin.
| .idea | ||
| .ra-target | ||
| bin | ||
| !/src/bin |
There was a problem hiding this comment.
Ah I see. In that case, we should just add the /bin pattern. instead of adding a ! of /src/bin.
YoganshSharma
force-pushed
the
chore/fix-gitignore
branch
from
c02f8a7 to
d6282d3
Compare
YoganshSharma
force-pushed
the
chore/fix-gitignore
branch
from
d6282d3 to
1b46bc0
Compare
Pull Request
Description
Allow tracking
src/bin/while continuing to ignore generated root-levelbin/artifacts.binwas added to.gitignorein #397 to avoid committing downloaded Bitcoin Core binaries. However, the broadbinignore rule also unintentionally ignores files insidesrc/bin/, which contains critical Rust binary entrypoint files.This PR also removes:
/docs/fidelity_bonds.mdfrom.gitignoreIf contributors want to keep local modifications to docs/fidelity_bonds.md untracked, that rule should be added locally in:
git/info/excludeinstead of the shared repository .gitignore.Type of Change
.gitignore cleanup
Protocol Version(s) Affected
messages.rs,contract.rs,handlers.rs)messages2.rs,contract2.rs,handlers2.rs)Affected Component(s)
docs/).gitignore cleanup
Checklist
Code Quality
cargo +nightly fmt --alland committed the resultcargo +stable clippy --all-features --lib --bins --tests -- -D warningswith zero warningscargo +stable clippy --examples -- -D warningswith zero warningsRUSTDOCFLAGS="-D warnings" cargo +nightly doc --all-features --document-private-items --no-depswith zero warningsln -s ../../git_hooks/pre-commit .git/hooks/pre-commitif not already set)Testing
cargo test)cargo test --features integration-test)#[cfg(feature = "integration-test")]Documentation
docs/folder were updatedSecurity & Privacy (Critical)
integration-testfeature flag is not reachable in production code pathsHow to Test
Summary by CodeRabbit
.gitignoreconfiguration to improve build artifact management and exclude additional development environment files and generated artifacts.