Skip to content

added-debug-loggin-by-default#60

Merged
keraliss merged 2 commits into
citadel-tech:mainfrom
ajey35:fix/enabled-debug-logging
Feb 10, 2026
Merged

added-debug-loggin-by-default#60
keraliss merged 2 commits into
citadel-tech:mainfrom
ajey35:fix/enabled-debug-logging

Conversation

@ajey35
Copy link
Copy Markdown
Contributor

@ajey35 ajey35 commented Jan 22, 2026

Enable Debug Logging by Default

This PR enables debug logging by default and fixes #59 broken log-level propagation.

Changes

  • Set default log level to debug in the Electron main process.
  • Pass the active logLevel to coinswap-worker.js.
  • Fix crash in taker:setupLogging caused by an undefined TakerClass.
  • Ensure worker logger uses the same log level as the main process.

Result

  • Debug logs enabled on fresh installs.
  • Consistent logging across main and worker processes.
  • Logging setup from the UI works correctly.

Files Changed

  • api1.js
  • coinswap-worker.js

Copy link
Copy Markdown
Collaborator

@keraliss keraliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but we also need a button on the log page to show the debug logs, like we have for info, warning and error. can you add that as well? one dedicated space for debug logs?

@ajey35
Copy link
Copy Markdown
Contributor Author

ajey35 commented Feb 6, 2026

Sure @keraliss — I’ll add a dedicated Debug button and section for debug logs as well.

@ajey35
Copy link
Copy Markdown
Contributor Author

ajey35 commented Feb 6, 2026

see the debug button added :
Screenshot From 2026-02-06 09-46-58

@ajey35 ajey35 requested a review from keraliss February 8, 2026 11:32
@keraliss
Copy link
Copy Markdown
Collaborator

you sure you've pushed the code? i am not seeing any new code or the debug section if i run locally!

@ajey35 ajey35 force-pushed the fix/enabled-debug-logging branch from 88659b6 to fb09da0 Compare February 10, 2026 15:37
@github-actions
Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@ajey35
Copy link
Copy Markdown
Contributor Author

ajey35 commented Feb 10, 2026

hello @keraliss I'm sorry , it is my fault , see now i pushed code

preview :
Screenshot From 2026-02-10 21-11-35

Copy link
Copy Markdown
Collaborator

@keraliss keraliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! Looks good!

@keraliss keraliss merged commit d41b665 into citadel-tech:main Feb 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enable debug logging by default for the app

2 participants