disabled-auto-sync-wallet-page#61
Closed
ajey35 wants to merge 2 commits into
Closed
Conversation
keraliss
requested changes
Jan 28, 2026
Collaborator
keraliss
left a comment
There was a problem hiding this comment.
You're disabling the auto sync totally, which is not the ideal ux.
The issue is that users expect to see updated data when:
- They first load the wallet page
- They send funds
- They receive funds
So we need a nuanced approach. we need to think of a way of triggering syncs when meaningful changes happen, like initial load, after tx, but stop the spontaneous triggers which is lagging the ui.
Simply removing all auto-sync means users see stale data ,or 0 balance on fresh load until they manually click refresh, which breaks expected behavior.we need to identify what is triggering the excessive sync and stop that.
Contributor
Author
|
okay @keraliss understood thanks for your time and guidance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabled Auto-Sync on Wallet Page
This PR fixes #58 that the wallet page does not auto-sync and only loads data from cache unless the user manually refreshes.
Verified Changes
updateBalance,updateTransactions,updateUtxosnow return early whenuseCache === true.useCache === false).Behavior
File Changed
src/components/wallet/Wallet.js