Fix IDA hearing notice defects: participation, category modules, subsidy

[jimdc]

Summary

User feedback on an IDA public-hearing notice (#notice/20250227021, from the homepage Past IDA meetings demo) reported four related defects, plus an age-aware gap principle: demo examples must backtest on old notices, and gap copy must distinguish too soon vs not published vs unavailable.

1. Duplicate participation buttons → one specific link

The notice body publishes the same EDC board URL twice, once with a trailing comma. Participation extraction now strips trailing punctuation before dedupe, keeps one outbound affordance, and labels the generic NYCIDA board page as IDA meetings page (the deepest public target this source publishes for that hearing).

2. List vs detail coherence

Meetings list cards and the notice permalink share one derivation: normalizeHearingRow → participationLinksHTML. The permalink now shows the same IDA meetings page action people need when sharing “how do I attend.”

3. Wrong-universe contract modules on hearings

Contract lifecycle, OCP award gaps, and PIN gap copy only render for procurement notices (isContractLifecycleEligible). Hearings, rules, property disposition, and staffing no longer stack Checkbook-style “not found” cards.

4. Subsidy “Could not reach” root cause

Root cause (evidence): GET https://edc.nyc/about-nycedc/financial-public-documents-recordings returns HTTP 403 Cloudflare challenge HTML to edge fetch, so fetchSubsidyProjects failed and the worker painted source_status: unavailable. Unavailable rows were also permanently written to D1, so recovery never happened.

Fix: treat challenge/empty feed as feed failure without permanent cache; when the feed is down, derive the hearing stage from the City Record IDA notice itself (projectFromIdaNotice). Keep the operational “Could not reach” copy only when the feed is down and no notice-derived hearing applies.

5. Age-aware gap copy + aged demos (backtest)

Three honest states for subsidy gaps: too_soon (typical lag not elapsed — check back), not_published (lag elapsed — class-b), unavailable (fetch failure only). Lag table: board ~60d, project_record ~90d, closing ~180d after hearing.

Aged demos that join the City Record hearing stage (backtest of the construct):

Notice	Hearing	Why it demos well
#notice/20220525018	2022-06-09	Multi-year aged; hearing join + later stages not_published
#notice/20231004016	2023-11-02	Aged 2023 IDA hearing
#notice/20240617012	2024-07-18	Aged 2024 IDA hearing

Honest limit: a full Build NYC document join (board packages, closing PDFs) is not available while the EDC documents page is Cloudflare-blocked to edge fetch. Aged notices prove the hearing-stage construct and age-aware later-stage copy; they do not invent board/closing rows without a public machine feed.

Young field case #notice/20260617040 (2026-07-16) correctly uses too_soon for later stages rather than “could not reach.”

Before / after

Screenshots under docs/screenshots/ida-notice-defects/ (production before / local after).

Surface	Before	After
Meetings list	duplicate Participation link	one IDA meetings page
Notice modules	Contract lifecycle + OCP + PIN + could-not-reach	no contract modules; age-aware subsidy
Notice actions	no participation	IDA meetings page

Test plan

• node --test test/ida_notice_defects.test.mjs (participation, category gate, age-aware, aged backtest)
• node --test test/lifecycle_coherence_field_cases.test.mjs test/gap_taxonomy.test.mjs test/subsidy_lifecycle.test.mjs
• python3 test/standards/i18n_keys.py
• Post-deploy: aged demos above; young hearings show check-back not permanent gap; no contract lifecycle on hearings

Notes for review

• Generic EDC board URL is intentional when that is the only published participation target; labeled IDA meetings page.
• Worker + static site both need deploy for end-to-end subsidy recovery on production.