Admin chat posts say they go out as CivFix (#138) - #34
Conversation
|
| .evt-msg-who { font-weight: 700; font-size: 12px; color: var(--sun-700); } | ||
| .evt-msg-when { font-family: var(--font-mono); font-size: 10px; color: var(--ink-4); } | ||
| .evt-msg-text { grid-column: 1 / -1; font-size: 12.5px; color: var(--ink); line-height: 1.4; } | ||
| .evt-post-hint { font-size: 11px; color: var(--ink-3); margin-top: 6px; } |
There was a problem hiding this comment.
.evt-post-hint introduces raw 11px typography and 6px spacing values. This violates the repository requirement to use design tokens for frontend styling; use the appropriate typography and spacing tokens instead. The requirement must be satisfied before merging.
Rule Used: # civfix review rules civfix is a live civic-tech platform that will hold government contracts. Review every PR for correctness, security and performance. Flag real defects with evidence; skip style nits that lint already covers. ## Repos - **... (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/admin/src/styles/admin.css
Line: 2511
Comment:
**Use design tokens**
`.evt-post-hint` introduces raw `11px` typography and `6px` spacing values. This violates the repository requirement to use design tokens for frontend styling; use the appropriate typography and spacing tokens instead. The requirement must be satisfied before merging.
**Rule Used:** # civfix review rules civfix is a live civic-tech platform that will hold government contracts. Review every PR for **correctness, security and performance**. Flag real defects with evidence; skip style nits that lint already covers. ## Repos - **... ([source](https://app.greptile.com/civfix/-/custom-context?memory=39a53925-3d93-4c82-980e-27b67393717d))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Part of civfix/issue-tracker#138
What changed
In the admin, the report chat box and the event update box now say that posts go out as CivFix, and report chat messages from the official CivFix account carry an "Official" pill. Admin.
Before you start
mainpushVerify
[Admin]
Regression
Removing a report chat message — [Admin]
Forwarding a chat message to the city — [Admin]
Posting an event update — [Admin]
Not covered