Skip to content

Admin chat posts say they go out as CivFix (#138) - #34

Merged
theobong merged 2 commits into
mainfrom
feat/official-sender-copy
Sep 23, 2026
Merged

theobong merged 2 commits into
mainfrom
feat/official-sender-copy

Conversation

@theobong

Copy link
Copy Markdown
Member

Part of civfix/issue-tracker#138

What changed

In the admin, the report chat box and the event update box now say that posts go out as CivFix, and report chat messages from the official CivFix account carry an "Official" pill. Admin.

Before you start

  • Where: staging (admin.civfix.dev) after the main push
  • Sign in as: operator
  • Data: a report you can post to, and an event with at least one attendee

Verify

[Admin]

  1. On the Dashboard, click the "Reports" tile header, click the "All" chip and open a report — Expect: the report detail shows a "Chat" section.
  2. Look at the chat box — Expect: its placeholder reads "Message the neighbors as CivFix…".
  3. Type a message and click "Post" — Expect: toast "Message posted to the report chat"; the new message's author is "CivFix" with a green "Official" pill, and hovering the pill shows "The official CivFix account".
  4. Look at a message a resident posted in the same chat — Expect: no "Official" pill.
  5. Click "Dashboard", click the "Events" tile header and open an event — Expect: under "Post update" the hint reads "Updates are posted as CivFix, not from your own account."

Regression

Removing a report chat message — [Admin]

  1. On your message, click "Remove", then "Remove" in the "Remove message" dialog — Expect: toast "Message removed"; the row reads "Message removed" with no "Official" pill.

Forwarding a chat message to the city — [Admin]

  1. On a report with a city contact, post a message that tags the city's @handle named in the hint under the box — Expect: the row shows both "Official" and "Forwarded to city".

Posting an event update — [Admin]

  1. On an event with attendees, type in the "Post an update to … attendees…" box and click "Post update" — Expect: toast "Update posted to attendees"; the new entry's author is "CivFix".
  2. Open an event with no attendees — Expect: the box reads "No attendees to message yet", "Post update" is disabled, and the hint still shows.

Not covered

  • Messages operators posted before chat posts moved to the official account came from their own accounts, so they show no "Official" pill.

@theobong
theobong merged commit 58c66dc into main Sep 23, 2026
1 check passed
@theobong
theobong deleted the feat/official-sender-copy branch September 23, 2026 22:28
@greptile-apps

greptile-apps Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

Not merge-safe until the repository's design-token requirement is satisfied.

Fix All in Claude CodeFindings

  1. P2 Use design tokens ▶
Fix with agent prompt
### Issue 1
apps/admin/src/styles/admin.css:2511
`.evt-post-hint` introduces raw `11px` typography and `6px` spacing values. This violates the repository requirement to use design tokens for frontend styling; use the appropriate typography and spacing tokens instead. The requirement must be satisfied before merging.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..."

.evt-msg-who { font-weight: 700; font-size: 12px; color: var(--sun-700); }
.evt-msg-when { font-family: var(--font-mono); font-size: 10px; color: var(--ink-4); }
.evt-msg-text { grid-column: 1 / -1; font-size: 12.5px; color: var(--ink); line-height: 1.4; }
.evt-post-hint { font-size: 11px; color: var(--ink-3); margin-top: 6px; }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Use design tokens

.evt-post-hint introduces raw 11px typography and 6px spacing values. This violates the repository requirement to use design tokens for frontend styling; use the appropriate typography and spacing tokens instead. The requirement must be satisfied before merging.

Rule Used: # civfix review rules civfix is a live civic-tech platform that will hold government contracts. Review every PR for correctness, security and performance. Flag real defects with evidence; skip style nits that lint already covers. ## Repos - **... (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/admin/src/styles/admin.css
Line: 2511

Comment:
**Use design tokens**

`.evt-post-hint` introduces raw `11px` typography and `6px` spacing values. This violates the repository requirement to use design tokens for frontend styling; use the appropriate typography and spacing tokens instead. The requirement must be satisfied before merging.

**Rule Used:** # civfix review rules  civfix is a live civic-tech platform that will hold government contracts. Review every PR for **correctness, security and performance**. Flag real defects with evidence; skip style nits that lint already covers.  ## Repos  - **... ([source](https://app.greptile.com/civfix/-/custom-context?memory=39a53925-3d93-4c82-980e-27b67393717d))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant