Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
A cleanup of comments and copy. Wasteful comments are gone, along with references to retired documents and prototypes and 49 empty leftovers from an old comment-stripping tool. Every em dash is removed from the dashboard. Only WHY comments remain.
The one visible change is copy:
Visible in: admin.
Before you start
admin.civfix.dev, once Admin test harness and characterization safety net #38, Admin security, crash and data-loss fixes #39, Admin correctness and accessibility fixes #40 and this PR have merged to main.Verify
[Admin]
Regression
Every section: [Admin]
Not covered
Findings addressed
{ }JSX expressions and the double blank lines are gone.NOTICEand user-facing copy. The README, the workflows andglobals.cssare cleaned in Admin repo hygiene: docs, env example, unused deps, favicon #32.eslint-disablefor exhaustive-deps is removed from the boundary map.Decisions for the reviewer
EMPTY_VALUE = "-"inlib/empty-value.ts. It now matches the server's own "-" sentinel. The trade-off: at default punctuation settings, some screen readers read a lone hyphen as silence. Change the one constant for another glyph.User-visible copy changes
features/discovery/discovery-page.tsx:586features/home/home-preview-presentation.ts:14queued — ${MODERATION_MIX}queued · ${MODERATION_MIX}features/mail/forward-template-modal.tsx:156${v.label} — ${v.description}}${v.label}: ${v.description}}features/pages/page-blocks.ts:63${when} — ${what}${when} · ${what}features/pages/page-blocks.ts:71${plain(entry.name)} — ${role}${plain(entry.name)} · ${role}features/reports/reports-page.tsx:1157Message ${report.city.dept} — e.g. nudge for an update…}Message ${report.city.dept}, e.g. nudge for an update…}features/discovery/discovery-page.tsx:416features/discovery/discovery-page.tsx:494features/discovery/discovery-page.tsx:671features/events/events-page.tsx:830features/home/home-page.tsx:104features/home/home-page.tsx:118features/home/home-page.tsx:132features/home/home-page.tsx:146features/home/home-page.tsx:172features/home/home-page.tsx:630features/mail/mail-page.tsx:426features/moderation/gov-claim-presentation.ts:74features/moderation/gov-claims-views.tsx:268features/moderation/moderation-page.tsx:784features/moderation/moderation-page.tsx:791features/orgs/create-org-panel.tsx:255features/orgs/orgs-page.tsx:166features/reports/reports-page.tsx:682features/reports/reports-page.tsx:998features/reports/reports-page.tsx:1276features/users/users-page.tsx:526features/users/users-page.tsx:557features/users/users-page.tsx:610features/users/users-page.tsx:766Tests changed
EMPTY_VALUEwith exact matches: dates, discovery chips, analytics cells, and the org profile facts.Verification
pnpm lint,pnpm typecheck,pnpm buildandpnpm testpass: 98 files, 1,056 tests.x-clientheader.git grepfor the em dash character finds only the three files Admin repo hygiene: docs, env example, unused deps, favicon #32 cleans: the README, the deploy workflow andglobals.css.🤖 Generated with Claude Code