Skip to content

Admin stylesheet cleanup, no visual change #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
theobong wants to merge 9 commits into from
Closed

Admin stylesheet cleanup, no visual change #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7da1cb2
styles: delete dead admin.css rules, empty media blocks and unused ke…
theobong Sep 24, 2026
f5bda57
styles: delete dead colors-and-type utility classes
theobong Sep 24, 2026
c84fd0e
styles: delete the dead op-login-error rule
theobong Sep 24, 2026
85d9e0a
merge the pr 5 branch
theobong Sep 24, 2026
b7f1ccf
styles: merge duplicate selectors and identical rule bodies
theobong Sep 24, 2026
2adac77
styles: raw hex colors that equal a token use the token
theobong Sep 24, 2026
ee45fc2
styles: drop class names that have no css rule
theobong Sep 24, 2026
503169d
styles: delete custom properties nothing references
theobong Sep 24, 2026
d19abd6
styles: css comments explain why, not what
theobong Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/admin/src/components/map/leaflet-map.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ const GLYPHS: Record<string, string> = {
"M12 9 a2 2 0 0 1 3 -1.3 a2 2 0 0 1 0.5 3 L12 14 L8.5 10.7 a2 2 0 0 1 0.5 -3 A2 2 0 0 1 12 9 Z M4 13 v5 a1 1 0 0 0 1 1 h2 v-6 Z M20 13 v5 a1 1 0 0 1 -1 1 h-2 v-6 Z",
}
const PIN_FILL: Record<string, string> = {
routed: "#8A8378",
routed: "var(--ink-3)",
needs: "#E5564B",
event: "#E5AE1C",
event: "var(--sun-600)",
"event-volunteer": "#5B8C6E",
}
// Event kinds own their fill and glyph; `draft` never overrides them.
Expand All @@ -82,8 +82,8 @@ function pinIcon(
const html =
`<div class="pi-pin2 ${state}${active ? " is-active" : ""}" style="width:${w}px;height:${h}px">` +
`<svg viewBox="0 0 64 76" width="${w}" height="${h}">` +
`<path d="${TEARDROP}" fill="${fill}" stroke="#fff" stroke-width="2.5"/>` +
`<g transform="translate(20 16)" stroke="#fff" stroke-width="2.2" stroke-linecap="round" stroke-linejoin="round" fill="none"><path d="${glyph}"/></g>` +
`<path d="${TEARDROP}" style="fill:${fill};stroke:var(--fg-on-color)" stroke-width="2.5"/>` +
`<g transform="translate(20 16)" style="stroke:var(--fg-on-color)" stroke-width="2.2" stroke-linecap="round" stroke-linejoin="round" fill="none"><path d="${glyph}"/></g>` +
`</svg>` +
`</div>`
return L.divIcon({
Expand Down
2 changes: 1 addition & 1 deletion apps/admin/src/features/analytics/analytics-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ export function AnalyticsPage(_props: SectionPageProps) {
return (
<div className="cat-breakdown">
{d.rows.map((r) => (
<div key={r.cat} className="cat-bd-row res-row">
<div key={r.cat} className="cat-bd-row">
<span className="cat-bd-dot" style={{ background: categoryCssVar(r.cat) }} />
<span className="cat-bd-name">{REPORT_CATEGORY_LABELS[r.cat]}</span>
<span className="cat-bd-track">
Expand Down
2 changes: 1 addition & 1 deletion apps/admin/src/features/home/home-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ function SectionTile({
label={`Pins per week, last ${s.spark.length} weeks: ${s.spark.join(", ")}`}
/>
) : (
<div className="hub-spark hub-spark-empty">No data yet</div>
<div className="hub-spark">No data yet</div>
))}
</div>
{s.metrics && (
Expand Down
2 changes: 1 addition & 1 deletion apps/admin/src/features/mail/mail-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ function ComposeEditor({ onClose, onSend, pending }: ComposeModalProps) {
<div className="modal-overlay" {...backdrop}>
<div
ref={modalRef}
className="modal compose-modal"
className="modal"
role="dialog"
aria-modal="true"
aria-labelledby={titleId}
Expand Down
2 changes: 1 addition & 1 deletion apps/admin/src/features/pages/page-preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function PagePreview({ cleanupId, title }: { cleanupId: string; title: st
// eslint-disable-next-line @next/next/no-img-element
<img className="pg-cover" src={page.coverUrl} alt="" />
)}
<div className="pg-seo">
<div>
<div className="pg-seo-title">{page.seo.title ?? title}</div>
{page.seo.description && <div className="pg-seo-desc">{page.seo.description}</div>}
<div className="pg-seo-meta mono">
Expand Down
Loading