Skip to content

Adopt @civfix/shared 0.58.0 - #43

Draft
theobong wants to merge 1 commit into
mainfrom
chore/adopt-shared-0.58.0
Draft

theobong wants to merge 1 commit into
mainfrom
chore/adopt-shared-0.58.0

Conversation

@theobong

Copy link
Copy Markdown
Member

What changed

Moves apps/admin from @civfix/shared ^0.57.0 to ^0.58.0, the campaign contract release from civfix/civfix-app#54.

Before you start

  • Draft: this waits for the publish. 0.58.0 is published when Contract release: @civfix/shared 0.58.0 civfix-app#54 (and the stack below it) merges into main. Until then the lockfile cannot resolve it, so this PR carries only the manifest range, and CI's frozen install fails by design.
  • After the publish: the lockfile is refreshed (pnpm install), committed with the manifest, and the PR is marked ready.
  • Where: staging (admin.civfix.dev) after the main merge.
  • Sign in as: an operator.

Verify

  1. Open admin.civfix.dev: the home screen, "Reports", a report's detail, "Mail", "Moderation", "Analytics" and the user list. Expect: every screen loads with the same data as before.
  2. Flag and unflag a report and an event. Expect: the same result as before (admin does not send the new flagged field yet).

Decisions for the reviewer

  • No admin code change is needed: apps/admin imports no removed export, and reads only id, category and label from WEB_REPORT_TYPES, which loses its placeholder gov field.
  • Adoption order:
    • Admin must ship this bump before the backend starts emitting the new optional response fields: url, removedBy, status, bouncedAt, KPI key and unit, and degraded.
    • The DTOs that carry them are .strict(), so an older admin would fail to parse them.
    • Sending flagged or excludeOrgId waits for the backend to implement them.
  • Follow-ups for the admin train, not in this PR: replace the hand-copied REPORT_STATUS_BUCKET with ADMIN_REPORT_STATUS_BUCKETS, and use toAppError(err, { fallbackMessage }) and isErrorCode in lib/api.ts.

Not covered

  • CI and staging run only after the publish and the lockfile refresh.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant