Mobile-web parity, share embeds, locate on grant, no mini-map (#129, #135, #136, #137)

.changeset/guest-readable-public-posts.md

@@ -0,0 +1,5 @@
+---
+"@civfix/shared": patch
+---
+
+`getPost` is `auth: "optional"`: a public post is guest-readable (share-link previews).

apps/community-mobile/APP-STORE-SUBMISSION-AUDIT.md

@@ -153,7 +153,7 @@ Permission↔usage parity is clean and there is **no tracking/ads/analytics SDK*
 Identity and asset pipeline are largely submission-ready (real reverse-DNS ids; marketing icon has **no alpha**; encryption flag accurate; OSM attribution present on the *main* map). The blocking work is operational + a couple of review/ToS risks. Note: `android/` and `ios/` are gitignored (regenerated by `expo prebuild`); **no `ios/` has ever been generated on this box**, so the iOS native build is unproven.
 
 - 🟠 **H9 — iPad supported while portrait-locked + phone-first.** `app.config.ts:43` `orientation:"portrait"` + `:55` `ios.supportsTablet:true`. With tablet support on, App Store Connect demands a full iPad screenshot set and reviewers test on iPad; a stretched iPhone layout draws 4.x design rejections. The shared UI adapts by width (≥840px sidebar shell) so it *may* pass, but must be verified on real iPad hardware. *Fix:* either commit to iPad (test + upload iPad screenshots) or set `supportsTablet:false`.
-- 🟠 **H10 — LocationPicker map disables OSM/CARTO attribution.** `LocationPicker.native.tsx:96-98` sets both `logo={false}` and `attribution={false}` and renders no text credit (only a "Tap the map to place the pin" hint), while drawing the same CARTO Voyager (OSM data) tiles as the home map. This violates the OSM Tile Usage Policy / CARTO basemap ToS on that screen. *(Compliant comparators: `MiniMap.native.tsx:56-58` draws a faint "CARTO / OSM" text credit; `Map.native.tsx:245` keeps the native (i) button.)* *Fix:* remove `attribution={false}` or add a static "© OpenStreetMap / CARTO" credit.
+- 🟠 **H10 — LocationPicker map disables OSM/CARTO attribution.** `LocationPicker.native.tsx:96-98` sets both `logo={false}` and `attribution={false}` and renders no text credit (only a "Tap the map to place the pin" hint), while drawing the same CARTO Voyager (OSM data) tiles as the home map. This violates the OSM Tile Usage Policy / CARTO basemap ToS on that screen. *(Compliant comparator: the home map, `Map.native.tsx`, keeps the native attribution control — the (i) button placed by `attributionPosition`.)* *Fix:* remove `attribution={false}` or add a static "© OpenStreetMap / CARTO" credit.
 - 🟡 **M12 — Release build signed with the debug keystore.** `android/app/build.gradle:118-121` `release` uses `signingConfigs.debug` (prebuild default; comment warns against it). Fine for local APKs, not for store upload. Informational since `android/` is regenerated. *Fix:* let EAS manage the upload keystore (`eas credentials`).
 - 🟡 **M14 — No `ios/` project + Google iOS URL scheme placeholder.** `app.config.ts:26` falls back to `com.googleusercontent.apps.PLACEHOLDER` when the env var is unset; an iOS build without the real reversed-client-id ships a non-functional Google sign-in scheme. Overlaps **B8**. *Fix:* set `EXPO_PUBLIC_GOOGLE_IOS_*` in the EAS env; run a macOS/EAS iOS build to validate.
 - 🟡 **M15 — New Architecture on + native libs pinned for compatibility.** `app.config.ts:46` `newArchEnabled:true`; README notes `react-native-mmkv` pinned to v3 and `vision-camera` to v4 to avoid Nitro, `react-native-compressor` excluded from the doctor check. Any module misbehaving under Fabric is a crash-on-launch risk. Not a config error — a **test obligation**. *Fix:* run the Play pre-launch report + a TestFlight pass on real devices (camera, MapLibre, video).
@@ -193,7 +193,7 @@ Expected: `ACCESS_COARSE/FINE_LOCATION`, `CAMERA`, `RECORD_AUDIO`, `POST_NOTIFIC
 - **Bundle id / package** are clean reverse-DNS (`org.civfix.community`), consistent iOS↔Android, no `com.example`/`com.anonymous`/`host.exp.exponent` leakage.
 - **Marketing icon** has no alpha; **fonts** (Baloo 2, Bricolage Grotesque, JetBrains Mono, Manrope) are OFL/Apache and Lucide is ISC — all redistributable, no restrictive assets.
 - **Prior `["threads"]` cache-collision crash** is now guarded with split query keys + tests (`packages/ui/src/data/__tests__/discussion-cache.test.ts`); low residual risk. Push-token and Google-sign-in failures are both wrapped non-fatal (dead-feature, not crash).
-- **Main map (home) shows OSM attribution** (`Map.native.tsx:245`) and `MiniMap` shows a text credit — only `LocationPicker` is non-compliant (H10).
+- **Main map (home) shows OSM attribution** (`Map.native.tsx`, the native attribution control at `attributionPosition`) — only `LocationPicker` is non-compliant (H10).
 
 ---
 

apps/community-mobile/app/index.tsx

@@ -11,6 +11,8 @@ import {
   useLayoutMode,
   Map as SharedMap,
   MapControls,
+  useMapFlyTo,
+  useMapFocus,
   useMapViewport,
   useReportFilterStore,
   enabledCategoriesArray,
@@ -273,9 +275,16 @@ export default function MapHomeScreen() {
   }, [])
 
   const resolveLocation = location.resolve
+  const awaitFirstFix = location.awaitFirstFix
 
   const recalledViewport = recallMapViewport() !== null
   const initialCenterOwnedRef = useRef(recalledViewport)
+
+  const onUserCameraMove = useCallback(() => {
+    initialCenterOwnedRef.current = true
+    beginCameraRequest()
+  }, [beginCameraRequest])
+
   const [rememberedCenter] = useState<RememberedCenter | null>(readLastCenter)
 
   const centerPlan = useMemo(
@@ -303,19 +312,25 @@ export default function MapHomeScreen() {
   const onLocate = useCallback(() => {
     const requestGeneration = beginCameraRequest()
     void (async () => {
-      const precise = await resolveLocation()
+      const { coords, prompted } = await resolveLocation()
       const fallback = approximatePointRef.current
       initialCenterOwnedRef.current = true
-      if (precise) {
+      if (coords) {
         adoptedSourceRef.current = "precise"
-        centerOnTarget({ ...precise, zoom: PRECISE_ZOOM }, requestGeneration)
+        centerOnTarget({ ...coords, zoom: PRECISE_ZOOM }, requestGeneration)
         return
       }
-      if (!fallback) return
-      adoptedSourceRef.current = "approximate"
-      centerOnTarget({ ...fallback, zoom: APPROX_ZOOM }, requestGeneration)
+      if (fallback) {
+        adoptedSourceRef.current = "approximate"
+        centerOnTarget({ ...fallback, zoom: APPROX_ZOOM }, requestGeneration)
+      }
+      if (!prompted) return
+      const firstFix = await awaitFirstFix()
+      if (!firstFix) return
+      adoptedSourceRef.current = "precise"
+      centerOnTarget({ ...firstFix, zoom: PRECISE_ZOOM }, requestGeneration)
     })()
-  }, [beginCameraRequest, centerOnTarget, resolveLocation])
+  }, [awaitFirstFix, beginCameraRequest, centerOnTarget, resolveLocation])
 
   const onboardingDone = useOnboardingStore((s) => s.completedVersion >= ONBOARDING_VERSION)
   const tourPresenting = useOnboardingStore((s) => s.presenting)
@@ -358,6 +373,7 @@ export default function MapHomeScreen() {
     if (!shouldAdoptCenter(adoptedSourceRef.current, source)) return
     adoptedSourceRef.current = source
     initialCenterOwnedRef.current = true
+    if (useMapFocus.getState().focus || useMapFlyTo.getState().highlight) return
     centerOnTarget(center)
   }, [centerPlan, seedCenter, centerOnTarget])
 
@@ -483,6 +499,7 @@ export default function MapHomeScreen() {
       <ManagedMap
         onMapHandle={setMapHandle}
         onInstanceRegionChange={onRegionChange}
+        onUserCameraMove={onUserCameraMove}
         initialCenter={mapSeed}
         reports={pins}
         reportAggregates={reportAggregates}
@@ -503,6 +520,7 @@ export default function MapHomeScreen() {
     seedCenter,
     setMapHandle,
     onRegionChange,
+    onUserCameraMove,
     location.coords,
     location.permission,
     pins,

apps/community-mobile/src/components/DetailRouteHost.tsx

@@ -20,7 +20,11 @@ import {
   shellStackBelow,
   useNestedShellStore,
 } from "@/lib/nestedShellSignal"
-import { secondaryShellBackAction } from "@/lib/secondaryShellBack"
+import {
+  secondaryShellBackAction,
+  secondaryShellLeaveAction,
+  type SecondaryShellLeaveAction,
+} from "@/lib/secondaryShellBack"
 
 export interface DetailRouteHostProps {
   entry: DetailEntry | null
@@ -98,19 +102,25 @@ export default function DetailRouteHost({ entry }: DetailRouteHostProps): React.
     }, [hostId, navigationRef]),
   )
 
-  const leave = useCallback(() => {
-    leftRef.current = true
-    if (router.canGoBack()) router.back()
-    else goHome(router)
-  }, [router])
+  const leave = useCallback(
+    (action: SecondaryShellLeaveAction) => {
+      leftRef.current = true
+      if (action === "home" || !router.canGoBack()) {
+        goHome(router)
+        return
+      }
+      router.back()
+    },
+    [router],
+  )
 
   const armedRef = useRef(false)
   useFocusEffect(
     useCallback(() => {
       if (useNavStore.getState().active === null && entryRef.current) seedEntry(entryRef.current)
       if (useNavStore.getState().active === null) {
         armedRef.current = false
-        leave()
+        leave("back")
         return
       }
       armedRef.current = true
@@ -121,7 +131,7 @@ export default function DetailRouteHost({ entry }: DetailRouteHostProps): React.
         }
         if (!armedRef.current) return
         armedRef.current = false
-        leave()
+        leave(secondaryShellLeaveAction(state.lastTransition))
       })
     }, [leave]),
   )

apps/community-mobile/src/hooks/useUserLocation.ts

@@ -1,30 +1,36 @@
 import { useEffect, useMemo, useState, useCallback } from "react"
 import * as Location from "expo-location"
 import type { LatLng } from "@civfix/shared/geocode"
-import { GPS_TIMEOUT_MS, LAST_KNOWN_MAX_AGE_MS, withTimeout } from "@/lib/withTimeout"
+import { FIRST_FIX_TIMEOUT_MS, GPS_TIMEOUT_MS, LAST_KNOWN_MAX_AGE_MS, withTimeout } from "@/lib/withTimeout"
 
 export type LocationPermission = "undetermined" | "granted" | "denied"
 
+export interface LocationRefreshResult {
+  coords: LatLng | null
+  prompted: boolean
+}
+
 export interface UserLocationState {
   permission: LocationPermission
   permissionResolved: boolean
   coords: LatLng | null
-  resolve: () => Promise<LatLng | null>
-  refresh: () => Promise<LatLng | null>
+  resolve: () => Promise<LocationRefreshResult>
+  refresh: () => Promise<LocationRefreshResult>
+  awaitFirstFix: () => Promise<LatLng | null>
 }
 
 export function useUserLocation(): UserLocationState {
   const [permission, setPermission] = useState<LocationPermission>("undetermined")
   const [permissionResolved, setPermissionResolved] = useState(false)
   const [coords, setCoords] = useState<LatLng | null>(null)
 
-  const readFix = useCallback(async (): Promise<LatLng | null> => {
+  const readFix = useCallback(async (timeoutMs: number = GPS_TIMEOUT_MS): Promise<LatLng | null> => {
     try {
       const pos =
         (await Location.getLastKnownPositionAsync({ maxAge: LAST_KNOWN_MAX_AGE_MS })) ??
         (await withTimeout(
           Location.getCurrentPositionAsync({ accuracy: Location.Accuracy.Balanced }),
-          GPS_TIMEOUT_MS,
+          timeoutMs,
         ))
       if (!pos) return null
       const next = { lat: pos.coords.latitude, lng: pos.coords.longitude }
@@ -35,17 +41,21 @@ export function useUserLocation(): UserLocationState {
     }
   }, [])
 
-  const refresh = useCallback(async (): Promise<LatLng | null> => {
+  const refresh = useCallback(async (): Promise<LocationRefreshResult> => {
+    const before = await Location.getForegroundPermissionsAsync().catch(() => null)
     const { status } = await Location.requestForegroundPermissionsAsync()
     setPermissionResolved(true)
     if (status !== Location.PermissionStatus.GRANTED) {
       setPermission("denied")
-      return null
+      return { coords: null, prompted: false }
     }
     setPermission("granted")
-    return readFix()
+    const prompted = before !== null && before.status !== Location.PermissionStatus.GRANTED
+    return { coords: await readFix(), prompted }
   }, [readFix])
 
+  const awaitFirstFix = useCallback(() => readFix(FIRST_FIX_TIMEOUT_MS), [readFix])
+
   useEffect(() => {
     let active = true
     void (async () => {
@@ -71,7 +81,8 @@ export function useUserLocation(): UserLocationState {
       coords,
       resolve: refresh,
       refresh,
+      awaitFirstFix,
     }),
-    [permission, permissionResolved, coords, refresh],
+    [permission, permissionResolved, coords, refresh, awaitFirstFix],
   )
 }

apps/community-mobile/src/lib/detailRouteRestore.test.ts

@@ -421,3 +421,12 @@ test("DetailRouteHost takes its snapshot through detailShellSnapshot, not a raw
   assert.match(host, /detailShellSnapshot\(useNavStore\.getState\(\)\.stack, seedKey, entryIdentity\)/)
   assert.doesNotMatch(host, /stack\.filter\(\(e\) => entryIdentity\(e\) !== seedKey\)/)
 })
+
+test("DetailRouteHost dismisses to the root shell when a view switch empties the store", () => {
+  const host = readFileSync(
+    join(dirname(fileURLToPath(import.meta.url)), "..", "components", "DetailRouteHost.tsx"),
+    "utf8",
+  )
+  assert.ok(host.includes("leave(secondaryShellLeaveAction(state.lastTransition))"))
+  assert.ok(host.includes('if (action === "home" || !router.canGoBack())'))
+})

apps/community-mobile/src/lib/secondaryShellBack.test.ts

@@ -1,6 +1,6 @@
 import assert from "node:assert/strict"
 import { test } from "node:test"
-import { secondaryShellBackAction } from "./secondaryShellBack.ts"
+import { secondaryShellBackAction, secondaryShellLeaveAction } from "./secondaryShellBack.ts"
 
 test("hardware back pops the store stack while a parent page remains beneath the top one", () => {
   assert.equal(secondaryShellBackAction(2, true), "pop-detail")
@@ -20,3 +20,18 @@ test("an empty store stack has nothing to pop, so the press falls through to the
   assert.equal(secondaryShellBackAction(0, true), "system")
   assert.equal(secondaryShellBackAction(0, false), "system")
 })
+
+test("a leave with no transition, or one caused by a pop, push, replace or restore, goes back to the route beneath", () => {
+  assert.equal(secondaryShellLeaveAction(null), "back")
+  assert.equal(secondaryShellLeaveAction({ type: "pop", count: 1 }), "back")
+  assert.equal(secondaryShellLeaveAction({ type: "push" }), "back")
+  assert.equal(secondaryShellLeaveAction({ type: "replace" }), "back")
+  assert.equal(secondaryShellLeaveAction({ type: "restore" }), "back")
+})
+
+test("a leave caused by a view switch dismisses to the root shell", () => {
+  assert.equal(secondaryShellLeaveAction({ type: "select" }), "home")
+  assert.equal(secondaryShellLeaveAction({ type: "select", consumes: true }), "home")
+  assert.equal(secondaryShellLeaveAction({ type: "seed" }), "home")
+  assert.equal(secondaryShellLeaveAction({ type: "reset" }), "home")
+})

apps/community-mobile/src/lib/secondaryShellBack.ts

@@ -1,7 +1,17 @@
+import type { NavTransition } from "@civfix/ui"
+
 export type SecondaryShellBackAction = "pop-detail" | "system"
 
 export function secondaryShellBackAction(stackLength: number, canPopRoute: boolean): SecondaryShellBackAction {
   if (stackLength > 1) return "pop-detail"
   if (stackLength === 1 && !canPopRoute) return "pop-detail"
   return "system"
 }
+
+export type SecondaryShellLeaveAction = "back" | "home"
+
+const VIEW_SWITCH_TRANSITIONS: ReadonlySet<NavTransition["type"]> = new Set(["select", "seed", "reset"])
+
+export function secondaryShellLeaveAction(transition: NavTransition | null): SecondaryShellLeaveAction {
+  return transition && VIEW_SWITCH_TRANSITIONS.has(transition.type) ? "home" : "back"
+}

apps/community-mobile/src/lib/withTimeout.ts

@@ -23,6 +23,8 @@
  */
 export const GPS_TIMEOUT_MS = 4000
 
+export const FIRST_FIX_TIMEOUT_MS = 15_000
+
 /**
  * Cap how OLD a CACHED device fix may be before we stop treating it as "where the user is".
  *