Keep a picked time inside the device's DST gap - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
On a phone or browser set to US time, picking 2:30 AM on the night the US clocks spring forward saved the event at 3:30 AM, even when the event's own time zone has a 2:30 that night (Arizona, for example). The picked time is now kept everywhere it is set, loaded or shown. For an event in the device's own zone, the form now says the time doesn't exist instead of quietly moving it. Web and mobile.
Before you start
dev/run.sh api, thendev/run.sh webor the mobile dev client), or staging after merge (civfix.dev / the TestFlight build)America/Los_Angeles, then reload. iPhone: Settings → General → Date & Time. Android: Settings → System → Date & time.Verify
[Web]
[Mobile]
Regression
Setting a time on an ordinary day — [Web] [Mobile]
Past times today are blocked — [Web] [Mobile]
Editing an event in another time zone — [Web] [Mobile]
Duplicating an event — [Web] [Mobile]
Shift times in sign-up slots — [Web] [Mobile]
Not covered