Skip to content

Admin volunteer hours contract - #59

Merged
byteful merged 5 commits into
mainfrom
feat/admin-user-hours-contract
Sep 30, 2026
Merged

byteful merged 5 commits into
mainfrom
feat/admin-user-hours-contract

Conversation

@byteful

@byteful byteful commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

What changed

This defines what the admin panel and backend exchange so an operator can list, credit and void a person's volunteer hours. The host's event hours data can now say a credit came from CivFix. Nothing new shows in web or mobile from this PR alone.

Before you start

Verify

This PR has no screen of its own. Its behaviour is exercised by the backend and admin PRs above. Here, check that nothing that shares it changed.

Regression

Host hours on a finished event — [Web] [Mobile]

  1. As the host, open the ended event — Expect: the "Volunteer hours" card shows the credited total and one row per attendee as before
  2. Tap "Host dashboard", then "Log volunteer hours" — Expect: the roster is prefilled with the logged hours
  3. Change one attendee's hours and tap "Log hours" — Expect: toast "Logged hours for attendees", where n counts every row with hours; the card shows the new value

Attendee receipt — [Web] [Mobile]

  1. As a credited attendee, open the ended event — Expect: "You were credited volunteer hours"
  2. Tap it — Expect: your profile opens on the "Hours" tab

Organization actions that need a reason — [Admin]

  1. Open "Organizations", pick an org, click "Suspend" — Expect: a "Reason (required)" prompt; "Suspend organization" is disabled until you type a reason
  2. Type a reason and confirm — Expect: toast " suspended"; then "Restore" with a reason gives " restored"
  3. Open the org's "Members" tab, open a member's actions menu, choose "Remove" — Expect: a "Reason (required)" prompt; cancel it

Not covered

  • The admin hours screens and endpoints are verified in their own PRs.

@byteful

byteful commented Sep 27, 2026

Copy link
Copy Markdown
Member Author

@greptileai

@greptile-apps

greptile-apps Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Critical risk] Adds admin endpoints to credit and void volunteer hours in user ledgers.

Do not merge until the shared-package version bump follows the repository requirement.

Findings

  1. P2 Version bypasses changesets ▶
Fix with agent prompt
### Issue 1
packages/shared/package.json:3
This changes `@civfix/shared` from 0.57.0 to 0.58.0 without a changeset, violating the directive that version bumps go through changesets rather than a direct manifest edit. The repository requirement must be satisfied before merging.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1) · Last reviewed commit: "Credited by CivFix label on event hours ..."

{
"name": "@civfix/shared",
"version": "0.57.0",
"version": "0.58.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Version bypasses changesets

This changes @civfix/shared from 0.57.0 to 0.58.0 without a changeset, violating the directive that version bumps go through changesets rather than a direct manifest edit. The repository requirement must be satisfied before merging.

Rule Used: # civfix review rules civfix is a live civic-tech platform that will hold government contracts. Review every PR for correctness, security and performance. Flag real defects with evidence; skip style nits that lint already covers. ## Repos - **... (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/shared/package.json
Line: 3

Comment:
**Version bypasses changesets**

This changes `@civfix/shared` from 0.57.0 to 0.58.0 without a changeset, violating the directive that version bumps go through changesets rather than a direct manifest edit. The repository requirement must be satisfied before merging.

**Rule Used:** # civfix review rules  civfix is a live civic-tech platform that will hold government contracts. Review every PR for **correctness, security and performance**. Flag real defects with evidence; skip style nits that lint already covers.  ## Repos  - **... ([source](https://app.greptile.com/civfix/-/custom-context?memory=39a53925-3d93-4c82-980e-27b67393717d))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

@byteful
byteful merged commit fe27902 into main Sep 30, 2026
5 of 6 checks passed
@byteful
byteful deleted the feat/admin-user-hours-contract branch September 30, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant