Repository navigation
Admin volunteer hours contract - #59
Conversation
|
| { | ||
| "name": "@civfix/shared", | ||
| "version": "0.57.0", | ||
| "version": "0.58.0", |
There was a problem hiding this comment.
This changes @civfix/shared from 0.57.0 to 0.58.0 without a changeset, violating the directive that version bumps go through changesets rather than a direct manifest edit. The repository requirement must be satisfied before merging.
Rule Used: # civfix review rules civfix is a live civic-tech platform that will hold government contracts. Review every PR for correctness, security and performance. Flag real defects with evidence; skip style nits that lint already covers. ## Repos - **... (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/shared/package.json
Line: 3
Comment:
**Version bypasses changesets**
This changes `@civfix/shared` from 0.57.0 to 0.58.0 without a changeset, violating the directive that version bumps go through changesets rather than a direct manifest edit. The repository requirement must be satisfied before merging.
**Rule Used:** # civfix review rules civfix is a live civic-tech platform that will hold government contracts. Review every PR for **correctness, security and performance**. Flag real defects with evidence; skip style nits that lint already covers. ## Repos - **... ([source](https://app.greptile.com/civfix/-/custom-context?memory=39a53925-3d93-4c82-980e-27b67393717d))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
What changed
This defines what the admin panel and backend exchange so an operator can list, credit and void a person's volunteer hours. The host's event hours data can now say a credit came from CivFix. Nothing new shows in web or mobile from this PR alone.
Before you start
Verify
This PR has no screen of its own. Its behaviour is exercised by the backend and admin PRs above. Here, check that nothing that shares it changed.
Regression
Host hours on a finished event — [Web] [Mobile]
Attendee receipt — [Web] [Mobile]
Organization actions that need a reason — [Admin]
Not covered