-
Notifications
You must be signed in to change notification settings - Fork 1
Page the admin inbox without skipping messages that share a millisecond (#138) #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import { describe, expect, it } from "vitest" | ||
| import type { Sql } from "../../src/db/client.js" | ||
| import { makeFakeSql } from "../helpers/fake-sql.js" | ||
| import { makeDrizzleInboundRepository } from "../../src/services/admin/inbound-repository.drizzle.js" | ||
| import { makeDrizzleInboxFeedRepository } from "../../src/services/admin/inbox-feed-repository.drizzle.js" | ||
|
|
||
| const A = "aaaaaaaa-0000-4000-8000-000000000001" | ||
| const B = "aaaaaaaa-0000-4000-8000-000000000002" | ||
| const TS = new Date("2027-01-01T00:00:00.123Z") | ||
| const INSTANT = "2027-01-01T00:00:00.123456Z" | ||
|
|
||
| const emailRow = (id: string) => ({ | ||
| source: "email", | ||
| id, | ||
| ts: TS, | ||
| received_at: TS, | ||
| cursor_at: INSTANT, | ||
| from_addr: "resident@example.com", | ||
| recipient: "support@civfix.org", | ||
| subject: "Probe", | ||
| preview_text: "Hello", | ||
| preview_html: null, | ||
| has_attachments: false, | ||
| status: "unread", | ||
| auth_verdict: null, | ||
| }) | ||
|
|
||
| const repos = { | ||
| "the inbox feed": (sql: Sql) => makeDrizzleInboxFeedRepository(sql), | ||
| "the unmatched inbox": (sql: Sql) => makeDrizzleInboundRepository(sql), | ||
| } | ||
|
|
||
| describe.each(Object.entries(repos))("%s keyset", (_name, make) => { | ||
| it("pages from the row's microsecond instant, not its millisecond Date", async () => { | ||
| const db = makeFakeSql([{ match: /inbound_emails/, rows: [emailRow(A), emailRow(B)] }]) | ||
| const repo = make(db.sql as unknown as Sql) | ||
|
|
||
| const first = await repo.list({ limit: 1 }) | ||
| expect(first.nextCursor).toBe(`${INSTANT}|${A}`) | ||
|
|
||
| await repo.list({ limit: 1, cursor: first.nextCursor! }) | ||
| const next = db.statements.at(-1)! | ||
| expect(next.values).toContain(INSTANT) | ||
| expect(next.values).not.toContainEqual(TS) | ||
| expect(next.sql).toContain("?::text::timestamptz") | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A composite cursor issued before this change contains only milliseconds. This code pads a legacy value such as
.123Zto.123000Z, and the new descending keyset queries then use that reconstructed value as an exact microsecond anchor. Continuing from a cursor for a row at.123900Zomits an older row at.123100Z, so operators continuing an existing inbox page after deployment can permanently miss messages. Keep millisecond-compatible continuation behavior for legacy composite cursors while using precise instants for newly emitted cursors.Artifacts
Legacy cursor integration test
Exact-microsecond cursor control
Legacy millisecond cursor failure
Combined cursor integration run
Prompt To Fix With AI