Repository navigation
Show an activity entry with no operator as System (#138) - #119
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of civfix/issue-tracker#138
What changed
In the admin activity feed, an entry with no operator behind it now shows "System" instead of "Operator", and an anonymous suggestion of a city contact shows "A neighbor". "Operator" stays only for an operator with no display name. No admin screen shows this feed yet. Admin.
Before you start
mainpushVerify
No admin screen reads the activity feed; "Not covered" gives the API check.
Regression
No admin screen or app flow reads the activity feed, so there is no flow to sweep.
Not covered
/v1/admin/activity— Expect: entries the system wrote, such as "Sent an outreach digest" or "A send to a jurisdiction failed", show "System" as who; entries by a named operator still show that operator's name.