Skip to content

Deploy jobs use GitHub environments - #131

Merged
byteful merged 2 commits into
mainfrom
chore/deploy-environments
Oct 5, 2026
Merged

byteful merged 2 commits into
mainfrom
chore/deploy-environments

Conversation

@byteful

@byteful byteful commented Oct 5, 2026

Copy link
Copy Markdown
Member

What changed

The backend's staging deploy job runs inside the GitHub staging environment (only main), and the production deploy job inside production, which waits for approval by a release reviewer. Image builds and the release verify/promote step are unchanged. No API behavior changes.

Before you start

Verify

  1. Open the "Deploy (staging)" run started by the merge — Expect: the deploy job shows the environment "staging", runs without waiting, and its availability and readiness checks pass.
  2. Open civfix.dev, sign in as the reviewer citizen and open any report — Expect: loads as before.
  3. In Actions, open "Deploy (staging)" → "Run workflow", pick any branch other than main, run it — Expect: the deploy job is refused before any step runs, with a message that the branch is not allowed to deploy to "staging".

Regression

Production release — [none]

  1. At the next release, open the "Deploy (production)" run — Expect: the verify/promote job runs straight away; the deploy job shows "Waiting" for review in "production" and only deploys after approval; the production app then serves the release.

Not covered

  • The production approval itself until the next release.
  • Release tags cut before this merge have no environment in their workflow and are not gated (secrets stay repo-level by decision).

@byteful
byteful merged commit 7060c3c into main Oct 5, 2026
3 checks passed
@byteful
byteful deleted the chore/deploy-environments branch October 5, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant