Draft
Conversation
cjrace
added
new feature
bump package versions bump pnpm version bump pnpm again helping bcrypt build in GHA undo python step in gha approve bcrypt and sharp builds specifically experimenting further with build script try adding a pnpmfile update lockfile testing testing testing
This reverts commit b5648cc.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…x only CSS left and framer-motion x were both applied, moving cows at 2x the intended distance. Now left is fixed at 0 and framer-motion owns all horizontal movement via translateX. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…sition raceTrackRect.right gives the distance from the left viewport edge to the element's right edge, which varies with scroll and screen size. Using raceTrackRect.width * 0.95 aligns the finish trigger with the visual finish line marker (right: 5%), minus the cow image width so the cow's leading edge crosses the line. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Previous lockfile was corrupted by an aborted dependency update attempt, with wrong minimatch dependencies, a dotenv version mismatch, and eslint appearing as a direct dependency not present in package.json. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- cowrace: convert number expressions to String() in template literals to satisfy restrict-template-expressions - cowrace: move setCowPositions/setWinners reset into startRace handler to satisfy react-hooks/set-state-in-effect (no synchronous setState in effect body) - irishbingo, snakesandladders: remove inferrable useState type arguments to satisfy no-unnecessary-type-arguments Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of changes
Added a cow racing game.
It's still pretty basic and needs prettying and polishing but gives a starting point.
Attempted a bunch of dependency updates, that caused a world of pain and got nowhere so reverted it for now.
Checklist
pnpm testReviewer instructions
Still having issues with the finish line calculation - it's not currently using the right measurements so messes up on different screen resolutions any help with this would be appreciated, tried a few things and it just keeps being too long (i.e. the cows run off the screen)