Skip to content

sync Main#66

Closed
cjy0812 wants to merge 6 commits into
plusfrom
main
Closed

sync Main#66
cjy0812 wants to merge 6 commits into
plusfrom
main

Conversation

@cjy0812

@cjy0812 cjy0812 commented May 21, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

Refactor

  • 优化内部代码结构和变量声明方式
  • 改进类型标注的清晰度
  • 调整资源加载路径配置

Review Change Stack

@cloudflare-workers-and-pages

This comment was marked as resolved.

@coderabbitai

This comment was marked as spam.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 463744828b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

node-version: latest

- uses: pnpm/action-setup@v4
- uses: pnpm/action-setup@v6

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Specify pnpm version for setup action

pnpm/action-setup@v6 only allows omitting with.version when package.json has a top-level packageManager field, but this commit also removes that field. In this workflow, the setup step now has no version source, so CI can fail before install/publish (or become non-deterministic if defaults change). Add an explicit with: version: ... here (or restore packageManager) to keep deploy runs reproducible.

Useful? React with 👍 / 👎.

@cjy0812 cjy0812 closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants