On screen logging#121
Merged
Merged
Conversation
| type t = int32 array | ||
| type t = { colors : int32 array; distinctive_pair : int * int } | ||
|
|
||
| let delta_e (luv1 : Hsluv.luv) (luv2 : Hsluv.luv) = |
Collaborator
There was a problem hiding this comment.
Got introduced to a new library! 🙌🙌
pawaskar-shreya
approved these changes
Sep 15, 2025
Collaborator
pawaskar-shreya
left a comment
There was a problem hiding this comment.
This is such a great addition to CLaudius. 🤩💫
Feels like a lot of features are being delicately tied together to have this log stats rendered to the sdl window.
And the idea with the color space is such a cool thing!
Firstly it is visually better than a single color being used in terms of visibility and secondly, it looks so much better with 2 colors being used for the log, one for the text body and other for the border. This again fits so perfectly with our theme for a retro console! 🤖
Such a cool PR this is! 🫡
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to address #93 and #91 - moving logging from Claudius from the terminal into the Claudius display. This turned out to be more messy that I'd anticipated, as it exposed some side-effecty bits of code and global state.